Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Autosubmit wrong log message for successful wrappers #2035

Closed
dbeltrankyl opened this issue Dec 16, 2024 · 2 comments
Closed

Autosubmit wrong log message for successful wrappers #2035

dbeltrankyl opened this issue Dec 16, 2024 · 2 comments
Assignees
@dbeltrankyl
Labels
bug Something isn't working working on Someone is working on it
Milestone
Autosubmit 4.1.12

Comments

@dbeltrankyl
Copy link
Contributor

Hello @kinow ,

As commented in Slack and some pull requests

Currently, in master, the log process retrieval is working for all platforms, but Autosubmit is raising a warning at the end of the run, wrongly indicating that some job logs couldn't be recovered.

I double-checked this, and I believe that's not right. I see the logs retrieved.
@dbeltrankyl dbeltrankyl added bug Something isn't working working on Someone is working on it labels Dec 16, 2024
@dbeltrankyl dbeltrankyl added this to the Autosubmit 4.1.12 milestone Dec 16, 2024
@dbeltrankyl dbeltrankyl self-assigned this Dec 16, 2024
@dbeltrankyl
Copy link
Contributor Author

PD: Probably we should close this one #1470

This was referenced Dec 17, 2024
Merged
Merged
@dbeltrankyl
Copy link
Contributor Author

dbeltrankyl commented Dec 17, 2024 •
edited
Loading

Ah, I thought I also put the other issue there, nvm I'll open a issue for #2038

@dbeltrankyl dbeltrankyl changed the title Autosubmit wrong log message for successful wrappers Autosubmit wrong log message for successful wrappers closes #2035 Dec 17, 2024
@dbeltrankyl dbeltrankyl changed the title Autosubmit wrong log message for successful wrappers closes #2035 Autosubmit wrong log message for successful wrappers Dec 17, 2024
isimo00 pushed a commit that referenced this issue Dec 23, 2024
@dbeltrankyl
Fixes wrapper warning message at the end closes #2035 (#2037)
c89b9f8 
* Fixes wrapper warning message at the end

* Added typing suggestion
isimo00 pushed a commit that referenced this issue Dec 27, 2024
parent 156b6e7
185336e 
author Irene Simo Munoz <irene.simomunoz@bsc.es> 1730215488 +0100
committer Irene Simo Munoz <irene.simomunoz@bsc.es> 1735301072 +0100

Add all expid_dir_path functions to autosubmit.py and fix tests !509

All previous definitions all expid_path, tmp_path, log_path and
aslogs_path (and similar) have been removed and their calls have been
switched for BasicConfig.foo() calls. Impacted tests are mainly affected
in terms of adding Mock objects since BasicConfig.foo() functions are
not available in autosubmitconfigparser yet. No new tests added

Fix batch of linter suggestions

 Fix issue with the is_wrapper attribute (#2033)

* Fix issue with the wrapper attribute

* Fix issue with the wrapper attribute

Changed the Log so it display what retrials it downloaded when it is a vertical wrapper (#2038)

Fixes wrapper warning message at the end closes #2035 (#2037)

* Fixes wrapper warning message at the end

* Added typing suggestion

updated timeout for pipeline

Fix batch of linter suggestions

Type checking and some fixes in mail functions

Changed the Log so it display what retrials it downloaded when it is a vertical wrapper (#2038)

Fixes wrapper warning message at the end closes #2035 (#2037)

* Fixes wrapper warning message at the end

* Added typing suggestion

updated timeout for pipeline

Add some other suggestions

Mail notifier BaseException to Exception
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dbeltrankyl dbeltrankyl

Labels
bug Something isn't working working on Someone is working on it
Projects
None yet
Milestone
Autosubmit 4.1.12
Development

No branches or pull requests
1 participant
@dbeltrankyl