(DEV VERSION ) Fix issue with the wrapper attribute #2033
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2033 +/- ##
==========================================
+ Coverage 48.93% 48.95% +0.02%
==========================================
Files 72 72
Lines 17525 17533 +8
Branches 3408 3410 +2
==========================================
+ Hits 8575 8583 +8
Misses 8150 8150
Partials 800 800
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
Was going to review this one, but it's showing a conflict in |
dbeltrankyl
force-pushed
the
is-wrapper
branch
from
718dd9c to
d3950c3
Compare
|
Hm, I didn't get a message about "the branch could not be merged anymore" like in gitlab Rebased |
kinow
approved these changes
Dec 17, 2024
|
I see you approved it, Ready to merge, then? |
|
Yup! An easy one :) |
isimo00
pushed a commit
that referenced
this pull request
Dec 23, 2024
* Fix issue with the wrapper attribute * Fix issue with the wrapper attribute
isimo00
pushed a commit
that referenced
this pull request
Dec 27, 2024
author Irene Simo Munoz <irene.simomunoz@bsc.es> 1730215488 +0100 committer Irene Simo Munoz <irene.simomunoz@bsc.es> 1735301072 +0100 Add all expid_dir_path functions to autosubmit.py and fix tests !509 All previous definitions all expid_path, tmp_path, log_path and aslogs_path (and similar) have been removed and their calls have been switched for BasicConfig.foo() calls. Impacted tests are mainly affected in terms of adding Mock objects since BasicConfig.foo() functions are not available in autosubmitconfigparser yet. No new tests added Fix batch of linter suggestions Fix issue with the is_wrapper attribute (#2033) * Fix issue with the wrapper attribute * Fix issue with the wrapper attribute Changed the Log so it display what retrials it downloaded when it is a vertical wrapper (#2038) Fixes wrapper warning message at the end closes #2035 (#2037) * Fixes wrapper warning message at the end * Added typing suggestion updated timeout for pipeline Fix batch of linter suggestions Type checking and some fixes in mail functions Changed the Log so it display what retrials it downloaded when it is a vertical wrapper (#2038) Fixes wrapper warning message at the end closes #2035 (#2037) * Fixes wrapper warning message at the end * Added typing suggestion updated timeout for pipeline Add some other suggestions Mail notifier BaseException to Exception
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Discovered in the t-suite week 50
What happens?
How to reproduce it