Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Panel2.cfg support #50

Merged
merged 18 commits into from
Mar 18, 2020
Merged

Add Panel2.cfg support #50

merged 18 commits into from
Mar 18, 2020

Conversation

cwfitzgerald
Copy link
Member

Looks quite similar to panel2, but they are different enough to not warrant combining.

Notable Changes:

  • Added HexColor3 and HexColor4 types for colors coming from HTML #XXXXXX notation.
  • Blu-tacked on file filtering to the corpus tester to reduce runtimes, will be fixed better by the PR that solves Reorganize Corpus Tester #39.
  • The Subject value type has a custom parser using nom due to its complexity.

DethRaid
DethRaid requested changes Mar 18, 2020
View reviewed changes
Copy link
Contributor

@DethRaid DethRaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add tests for the HexColors

bve/src/datatypes.rs Outdated Show resolved Hide resolved
bve/src/datatypes.rs Outdated Show resolved Hide resolved
bve/src/parse/panel2_cfg/sections/subject.rs Show resolved Hide resolved
bve/src/parse/panel2_cfg/sections/this.rs Show resolved Hide resolved
@cwfitzgerald cwfitzgerald merged commit 0df9519 into master Mar 18, 2020
@cwfitzgerald cwfitzgerald deleted the panel2_cfg branch March 18, 2020 03:25
@cwfitzgerald cwfitzgerald mentioned this pull request Mar 18, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DethRaid DethRaid DethRaid approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cwfitzgerald @DethRaid