DumpData: Refactor for glTF export in BN #17365

alexchuber · 2025-10-29T17:40:53Z

This PR adds the glue code to enable DumpData usage in BN with the glTF exporter.

Changes:

Factor out core image encoding to a separate function matching NativeEncoding's own exposed function name. This follows the current nativeOverride pattern for module-level functions (see the MathHelper class.)
Remove the bitmaprenderer path. I initially planned for Native to polyfill this, but that turned out to be not a good idea.
Fix case in glTF exporter where exporting images to a specific format could lead to invalid images if the browser or platform didn't support it.

…ot assignable to type '(pixelData: Uint8Array<ArrayBufferLike>, width: number, height: number, mimeType: string, invertY: boolean, quality?: number | undefined) => Promise<...>'. Type 'unknown' is not assignable to type 'Promise<ArrayBuffer>'.

bjsplat · 2025-10-29T17:42:25Z

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

packages/dev/core/src/Misc/dumpTools.ts

bjsplat · 2025-10-29T17:57:12Z

Snapshot stored with reference name:
refs/pull/17365/merge

Test environment:
https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/17365/merge/index.html

To test a playground add it to the URL, for example:

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/17365/merge/index.html#WGZLGJ#4600

Links to test babylon tools with this snapshot:

https://playground.babylonjs.com/?snapshot=refs/pull/17365/merge
https://sandbox.babylonjs.com/?snapshot=refs/pull/17365/merge
https://gui.babylonjs.com/?snapshot=refs/pull/17365/merge
https://nme.babylonjs.com/?snapshot=refs/pull/17365/merge

To test the snapshot in the playground with a playground ID add it after the snapshot query string:

https://playground.babylonjs.com/?snapshot=refs/pull/17365/merge#BCU1XR#0

bjsplat · 2025-10-29T18:02:41Z

WebGL2 visualization test reporter:

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/17365/merge/testResults/webgl2playwright/index.html

bjsplat · 2025-10-29T18:04:30Z

Visualization tests for WebGPU

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/17365/merge/testResults/webgpuplaywright/index.html

bjsplat · 2025-10-29T18:12:10Z

Interaction tests

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/17365/merge/testResults/interactionplaywright/index.html

packages/dev/core/src/Misc/dumpTools.ts

packages/dev/core/src/Misc/decorators.ts

packages/dev/core/src/Misc/dumpTools.ts

bjsplat · 2025-10-30T23:32:25Z

Interaction tests

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/17365/merge/testResults/interactionplaywright/index.html

bjsplat · 2025-10-30T23:36:26Z

Devhost visualization test reporter:

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/17365/merge/testResults/devhostplaywright/index.html

bjsplat · 2025-10-30T23:41:16Z

Visualization tests for WebGPU

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/17365/merge/testResults/webgpuplaywright/index.html

bjsplat · 2025-10-30T23:42:39Z

WebGL2 visualization test reporter:

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/17365/merge/testResults/webgl2playwright/index.html

bjsplat · 2025-11-03T18:09:02Z

Interaction tests

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/17365/merge/testResults/interactionplaywright/index.html

bjsplat · 2025-11-03T18:16:49Z

Devhost visualization test reporter:

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/17365/merge/testResults/devhostplaywright/index.html

bjsplat · 2025-11-03T18:23:09Z

WebGL2 visualization test reporter:

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/17365/merge/testResults/webgl2playwright/index.html

bjsplat · 2025-11-03T18:38:01Z

Visualization tests for WebGPU

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/17365/merge/testResults/webgpuplaywright/index.html

…sync, which doesn't exist in the core UMD build

bjsplat · 2025-11-03T22:51:59Z

Interaction tests

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/17365/merge/testResults/interactionplaywright/index.html

bjsplat · 2025-11-03T22:56:02Z

Devhost visualization test reporter:

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/17365/merge/testResults/devhostplaywright/index.html

bjsplat · 2025-11-03T22:58:49Z

WebGL2 visualization test reporter:

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/17365/merge/testResults/webgl2playwright/index.html

bjsplat · 2025-11-03T22:59:59Z

Visualization tests for WebGPU

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/17365/merge/testResults/webgpuplaywright/index.html

packages/dev/core/src/Misc/index.ts

bjsplat · 2025-11-04T16:46:17Z

Interaction tests

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/17365/merge/testResults/interactionplaywright/index.html

bjsplat · 2025-11-04T16:51:46Z

WebGL2 visualization test reporter:

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/17365/merge/testResults/webgl2playwright/index.html

bjsplat · 2025-11-04T16:52:38Z

Visualization tests for WebGPU

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/17365/merge/testResults/webgpuplaywright/index.html

bjsplat · 2025-11-04T16:53:35Z

Devhost visualization test reporter:

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/17365/merge/testResults/devhostplaywright/index.html

bjsplat · 2025-11-04T18:20:41Z

Interaction tests

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/17365/merge/testResults/interactionplaywright/index.html

bjsplat · 2025-11-04T18:23:32Z

Devhost visualization test reporter:

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/17365/merge/testResults/devhostplaywright/index.html

bjsplat · 2025-11-04T18:30:25Z

Visualization tests for WebGPU

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/17365/merge/testResults/webgpuplaywright/index.html

bjsplat · 2025-11-04T18:37:54Z

WebGL2 visualization test reporter:

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/17365/merge/testResults/webgl2playwright/index.html

This PR brings NativeEncoding up to speed with the changes in [BabylonJS #17365](BabylonJS/Babylon.js#17365). It also updates the unit tests accordingly. - Expect input[0] to be an ArrayBufferView, not necessarily a Uint8Array - Include Blob in BabylonNative build - Return Blob from EncodeImageAsync - Don't throw on unsupported MIME type - Use std::byte for clarity

alexchuber added 5 commits October 29, 2025 01:53

Remove bitmaprenderer

ffa3e0f

Experimentation with native implementation

6a82e50

Decided on Promise<ArrayBuffer>

7292799

Just use nativeOverride method decorator

0774434

alexchuber commented Oct 29, 2025

View reviewed changes

packages/dev/core/src/Misc/dumpTools.ts Outdated Show resolved Hide resolved

alexchuber mentioned this pull request Oct 29, 2025

glTF Exporter: Handle unsupported encode formats at platform level #17366

Closed

alexchuber requested a review from bghgary October 29, 2025 20:53

bghgary requested a review from ryantrem October 29, 2025 20:55

alexchuber commented Oct 29, 2025

View reviewed changes

packages/dev/core/src/Misc/dumpTools.ts Outdated Show resolved Hide resolved

bghgary reviewed Oct 29, 2025

View reviewed changes

packages/dev/core/src/Misc/dumpTools.ts Outdated Show resolved Hide resolved

packages/dev/core/src/Misc/dumpTools.ts Outdated Show resolved Hide resolved

packages/dev/core/src/Misc/dumpTools.ts Show resolved Hide resolved

ryantrem reviewed Oct 30, 2025

View reviewed changes

packages/dev/core/src/Misc/decorators.ts Show resolved Hide resolved

packages/dev/core/src/Misc/dumpTools.ts Outdated Show resolved Hide resolved

packages/dev/core/src/Misc/dumpTools.ts Show resolved Hide resolved

Use ArrayBufferView

d91fbff

alexchuber added 2 commits October 31, 2025 18:22

Try a Blob-first approach; no more throwing on unexpected mime

b6b3b36

glTF Exporter: Handle unsupported encode formats at platform level

5dcb498

Without this, the serializer UMD build looks for BABYLON.EncodeImageA…

436a9cf

…sync, which doesn't exist in the core UMD build

Bump down promise

b691a94

alexchuber commented Nov 4, 2025

View reviewed changes

packages/dev/core/src/Misc/index.ts Outdated Show resolved Hide resolved

facepalm

8fa3093

bghgary approved these changes Nov 4, 2025

View reviewed changes

alexchuber mentioned this pull request Nov 4, 2025

Playground: Add glTF serializer test BabylonJS/BabylonNative#1565

Draft

alexchuber merged commit 0af8c55 into BabylonJS:master Nov 4, 2025
20 checks passed

alexchuber changed the title ~~DumpData: Add Native override~~ DumpData: Refactor for glTF export in BN Nov 4, 2025

alexchuber deleted the dump-data-native branch November 4, 2025 21:40

alexchuber mentioned this pull request Nov 5, 2025

NativeEncoding: Use ArrayBufferView input and return Blob BabylonJS/BabylonNative#1564

Merged

DumpData: Refactor for glTF export in BN #17365

DumpData: Refactor for glTF export in BN #17365

Conversation

alexchuber commented Oct 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

bjsplat commented Oct 29, 2025

Uh oh!

Uh oh!

bjsplat commented Oct 29, 2025

Uh oh!

bjsplat commented Oct 29, 2025

Uh oh!

bjsplat commented Oct 29, 2025

Uh oh!

bjsplat commented Oct 29, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

bjsplat commented Oct 30, 2025

Uh oh!

bjsplat commented Oct 30, 2025

Uh oh!

bjsplat commented Oct 30, 2025

Uh oh!

bjsplat commented Oct 30, 2025

Uh oh!

bjsplat commented Nov 3, 2025

Uh oh!

bjsplat commented Nov 3, 2025

Uh oh!

bjsplat commented Nov 3, 2025

Uh oh!

bjsplat commented Nov 3, 2025

Uh oh!

bjsplat commented Nov 3, 2025

Uh oh!

bjsplat commented Nov 3, 2025

Uh oh!

bjsplat commented Nov 3, 2025

Uh oh!

bjsplat commented Nov 3, 2025

Uh oh!

Uh oh!

bjsplat commented Nov 4, 2025

Uh oh!

bjsplat commented Nov 4, 2025

Uh oh!

bjsplat commented Nov 4, 2025

Uh oh!

bjsplat commented Nov 4, 2025

Uh oh!

bjsplat commented Nov 4, 2025

Uh oh!

bjsplat commented Nov 4, 2025

Uh oh!

bjsplat commented Nov 4, 2025

Uh oh!

bjsplat commented Nov 4, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

alexchuber commented Oct 29, 2025 •

edited

Loading