-
Notifications
You must be signed in to change notification settings - Fork 152
NativeEncoding: Use ArrayBufferView input and return Blob #1564
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
alexchuber
merged 8 commits into
BabylonJS:master
from
alexchuber:native-encoding-updates
Nov 6, 2025
Merged
NativeEncoding: Use ArrayBufferView input and return Blob #1564
alexchuber
merged 8 commits into
BabylonJS:master
from
alexchuber:native-encoding-updates
Nov 6, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cf8e04b to
2ca2076
Compare
alexchuber
commented
Nov 4, 2025
bghgary
approved these changes
Nov 4, 2025
alexchuber
commented
Nov 5, 2025
…l Blob before we can (see NativeEngine.ts)
2ce9de9 to
a101b0e
Compare
alexchuber
added a commit
that referenced
this pull request
Nov 8, 2025
This PR adds a quick test for the glTF serializer in the Playground, updating BJS along the way. - Upgrade BJS to latest (8.36.1) - Fix installation test failure introduced in #1564 - Add the Blob polyfill, NativeEncoding plugin, and babylonjs-serializers package throughout the Playground app - Port a visualization test for the glTF serializer from BJS - Note: I would port over more, but the rest happen to use the File API, which is not yet supported in Native. --------- Co-authored-by: Demi <213505693+Debugmi@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR brings NativeEncoding up to speed with the changes in BabylonJS #17365. It also updates the unit tests accordingly.