Skip to content

Conversation

@alexchuber
Copy link
Contributor

@alexchuber alexchuber commented Nov 4, 2025

This PR brings NativeEncoding up to speed with the changes in BabylonJS #17365. It also updates the unit tests accordingly.

  • Expect input[0] to be an ArrayBufferView, not necessarily a Uint8Array
  • Include Blob in BabylonNative build
  • Return Blob from EncodeImageAsync
  • Don't throw on unsupported MIME type
  • Use std::byte for clarity

@alexchuber alexchuber changed the title Use ArrayBufferView input and return Blob NativeEncoding: Use ArrayBufferView input and return Blob Nov 4, 2025
@alexchuber alexchuber force-pushed the native-encoding-updates branch from cf8e04b to 2ca2076 Compare November 4, 2025 21:25
@alexchuber alexchuber marked this pull request as ready for review November 5, 2025 01:07
@alexchuber alexchuber marked this pull request as draft November 5, 2025 22:32
@alexchuber alexchuber force-pushed the native-encoding-updates branch from 2ce9de9 to a101b0e Compare November 6, 2025 02:01
@alexchuber alexchuber marked this pull request as ready for review November 6, 2025 02:13
@alexchuber alexchuber merged commit 274482f into BabylonJS:master Nov 6, 2025
19 checks passed
alexchuber added a commit that referenced this pull request Nov 8, 2025
This PR adds a quick test for the glTF serializer in the Playground,
updating BJS along the way.

- Upgrade BJS to latest (8.36.1)
- Fix installation test failure introduced in #1564
- Add the Blob polyfill, NativeEncoding plugin, and
babylonjs-serializers package throughout the Playground app
- Port a visualization test for the glTF serializer from BJS
- Note: I would port over more, but the rest happen to use the File API,
which is not yet supported in Native.

---------

Co-authored-by: Demi <213505693+Debugmi@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants