Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

do not have same dependency in dependencies and peerDependencies #2

Closed
vvakame opened this issue Nov 21, 2014 · 1 comment · Fixed by #3
Closed

do not have same dependency in dependencies and peerDependencies #2

vvakame opened this issue Nov 21, 2014 · 1 comment · Fixed by #3

Comments

@vvakame
Copy link

vvakame commented Nov 21, 2014

detail npm/npm#6506 (comment)

@IgorMinar
Copy link
Contributor

I sent a PR for this. The reason why fixing this is important is that npm fails and complains about this package.json when shrinkwrapping a project that uses minitable directly or as a transitive dependency.

So any project that depends on minitable directly or transitively needs to manually tweak the minitable package.json during each npm upgrade and re-shrinkwrap.

Since tsd (typescript type definition manager) depends on minitable, any typescript + npm project that shrinkwraps dependencies is affected.

Please merge #3 and cut a new version so that we can get tsd to update.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants