-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(package.json): don't define minichain dependency in both deps and… #3
Conversation
Oh, I was about to open a PR for this but it looks like Igor was faster :-) |
@pkozlowski-opensource good point. in tsd's case the ministyle dep is not a problem because it is required by tsd itself, so the peerdependency is actually there. |
so, for the purposes of solving our particular problem, I don't think we care about ministyle. |
@IgorMinar that means our backup plan is just to add an explicit dep from tsd to minichain, we don't need to fork minitable too. |
fix(package.json): don't define minichain dependency in both deps and…
Sorry for the wait guys, life went another way. Lemme get back on the horse and I'll get the things sorted out. |
Thank you! On Wed, May 20, 2015 at 10:53 AM Bart van der Schoor <
|
This is on npm as 0.0.4. Now we hustle a new TSD release as apparently I pinned only this module to an exact version.. 😕 |
I just realized I only merged the PR but not appreciated the discussion. So let me know if you also need the other peerDependency removed. |
it's weird that ministyle is both |
thanks for merging the PR though! let's get a TSD release out so that this major PITA is over. |
… devDeps
Fixes #2