Ensure goenv and go play together well #1824
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cornfeedhobo
force-pushed
the
goenv-go
branch
2 times, most recently
from
e4c2a11
to
bcc678e
Compare
This PR seeks to address several issues surrounding the go and goenv plugins. The nature of goenv allows for a situation where the initial shell does not point to a working go binary, and instead at the included shim script. The result is that one must run reload after moving to a project directory with a version file, however in doing so, PATH is updated, requiring they exit the shell or risk lookup collisions and unexpected behavior. This is solved by using preexec to check the version before changing directories and restarting the shell if the version has changed. The exec pattern is copied from _bash-it-restart, but is edited to support this specific use case. Additionally, tests have been uploaded and these are now being linted.
cornfeedhobo
force-pushed
the
goenv-go
branch
from
bcc678e
to
e690f21
Compare
|
I'd like to look into the composure issues before merging this. hold on to your butts |
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR seeks to address several issues surrounding the go and goenv plugins.
The nature of goenv allows for a situation where the initial shell does not
point to a working go binary, and instead at the included shim script. The
result is that one must run reload after moving to a project directory with a
version file, however in doing so, PATH is updated, requiring they exit the
shell or risk lookup collisions and unexpected behavior.
This is solved by using preexec to check the version before changing
directories and restarting the shell if the version has changed. The exec
pattern is copied from _bash-it-restart, but is edited to support this specific
use case.
Additionally, tests have been updated and these are now being linted.
How Has This Been Tested?
manually and locally. opening up for discussion while I continue such testing.
Screenshots (if appropriate):
Types of changes
Checklist:
clean_files.txtand formatted it usinglint_clean_files.sh.