Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure goenv and go play together well #1824

Merged
merged 1 commit into from
Feb 5, 2021

Commits on Feb 5, 2021

  1. Ensure goenv and go play together well

    This PR seeks to address several issues surrounding the go and goenv plugins.
    The nature of goenv allows for a situation where the initial shell does not
    point to a working go binary, and instead at the included shim script. The
    result is that one must run reload after moving to a project directory with a
    version file, however in doing so, PATH is updated, requiring they exit the
    shell or risk lookup collisions and unexpected behavior.
    
    This is solved by using preexec to check the version before changing
    directories and restarting the shell if the version has changed. The exec
    pattern is copied from _bash-it-restart, but is edited to support this specific
    use case.
    
    Additionally, tests have been uploaded and these are now being linted.
    cornfeedhobo committed Feb 5, 2021
    Configuration menu
    Copy the full SHA
    e690f21 View commit details
    Browse the repository at this point in the history