Fixes for Computer Smoothing #10015
Merged
Fixes for Computer Smoothing #10015
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tsar-Salat
reviewed
Oct 12, 2023
PestoVerde322
approved these changes
Oct 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About The Pull Request
Fixes a few emergent issues with #9834
Resolves #9986
Apparently I didn't fully realize how many combinations bitmask smoothing actually uses, some icons states were wrong in console.dmi, and a few other computers were attempting to smooth when they shouldn't have (they had special icons); I've included a lot of testing below because of this.
Why It's Good For The Game
Fixes and polishes are generally positive, good things.
Testing Photographs and Procedure
Update 4:20 PM UTC-6, 10/15/2023: BSA computers no longer disappear as well, and added testing evidence for that. (Thanks to Dejaku for pointing them out)
Computer Smoothing
Blocks of Computers (shows off
BITMASK_SMOOTH_SKIP_CORNERS)Variety of computer arrangements
Broken Consoles show up with states correctly
Narsie and Ratvar acts
Ratvar and Narsie acts
2023-10-11.21-45-31.mp4
Solar Panel Consoles
Excluded from Smoothing
Abductor Advanced Camera
Ratvar Camera Console
Mining Aux Base Computer
BSA Computer
Modular Computers
Overlays Working
ModularComputerOverlayStuff.mp4
Blocks of Modular Computers
Mixed Computer Smoothing
Changelog
🆑
imageadd: Modular Console on/off icon states are now separated into body and keyboard states instead of being combined
code: Added another bitflag for smoothing, SMOOTH_BITMASK_SKIP_CORNERS
fix: Modular Consoles no longer look fully broken when only the CPU is broken
fix: Fixed computers becoming invisible in certain arrangements
fix: Some computers with special icons no longer become invisible
fix: Computers now handle smoothing properly when acted on by Narsie or Ratvar
fix: Broken computers now show up properly
/:cl: