-
-
Notifications
You must be signed in to change notification settings - Fork 684
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Computer smoothing from Bay #9834
Computer smoothing from Bay #9834
Conversation
I don't like the north and south icons, they look like it's extruding or like a mini console. The ones from the side look nice. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Kinda wish we had unit tests to ensure that anything being smoothed has the correct icons for smoothing so we don't have problems in the future, but that's non-blocking.
Bit above my knowledge atm. So far, the only smoothing group needing unique behavior is computers, as walls and tables all used the same stuff. Not really worried about the maintainability if its limited to one thing. Ive spawned in multiple different orientations that players may use, so I think our bases are covered for now |
Ports:
About The Pull Request
Ports computer smoothing from a bay downstream
Adds new smoothing group, to work with directional objects, as smoothing is traditionally only has been used for walls and structures. Not stuff with faces and dirs
Why It's Good For The Game
It looks good. It makes administrative centers cluttered with all these damn consoles look semi-organized and sci-fi.
It fits Bridge and shuttle vibes.
A bunch of cluttered individual consoles doesn't look like a control panel, it looks like a mess.
Testing Photographs and Procedure
Changelog
🆑 RKz, HowToLoLu/Dakae, Baystation Spriters(ImJustKisik)
add: new smoothing group, includes computers and modular consoles
code: new smoothing_flag, directional smoothing, for stuff with dirs and faces
/:cl: