Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes nucleium engine turfs not working #2613

Merged
merged 1 commit into from
Mar 29, 2024

Conversation

DeltaFire15
Copy link
Contributor

About The Pull Request

Soooo it appears someone or a few someones write "Nucleium" as "Nucleum", which has led to a few broken things, including a bunch of runtimes during atmos init for any ship with floors that are supposed to have nucleium, since.. nucleum doesn't exist.

This replaces every single mention of "nucleum" on any map / code with "nucleium" as I could just adjust the few lines that runtime, but keeping it that way would ensure someone reads an incorrect line & creates the same situation again.

Why It's Good For The Game

Fix man good.

Testing Photographs and Procedure

. .. .

Changelog

🆑
fix: Nucleium engine turfs now work. As may some other map cases of "nucleum" being used as incorrect term.
spellcheck: "nucleum" -> "nucleium"
/:cl:

the two paths: change one line, and accept that someone will use the wrong term again.. ooor adjust every single mention..
@DeltaFire15 DeltaFire15 added Galactica Tycoon Gladius Aetherwisp Mass Map Change This PR will likely change two or more maps in order to implement its primary feature. labels Mar 5, 2024
@DeltaFire15 DeltaFire15 requested a review from a team as a code owner March 5, 2024 17:35
@DeltaFire15 DeltaFire15 added the Fix label Mar 5, 2024
@Bokkiewokkie Bokkiewokkie merged commit 67067fc into BeeStation:master Mar 29, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants