Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add output channel access API #41

Merged
merged 4 commits into from
May 9, 2022
Merged

Add output channel access API #41

merged 4 commits into from
May 9, 2022

Conversation

PEZ
Copy link
Collaborator

@PEZ PEZ commented May 9, 2022

  • Stops always showing the Joyride output channel on script runs
  • Adds joyride.core/get-output-channel function
  • Update to Joyride API example

Fixes #36

NB: This PR builds on to of #39, so please review that one first.

@PEZ PEZ requested a review from borkdude May 9, 2022 07:13
@borkdude
Copy link
Collaborator

borkdude commented May 9, 2022

LGTM but same remark as #39, I'd prefer if we could leave out the get- prefixes.

Base automatically changed from 4-invoked-script to master May 9, 2022 08:08
@PEZ
Copy link
Collaborator Author

PEZ commented May 9, 2022

I hear ya about the get-. Will fix!

@PEZ PEZ mentioned this pull request May 9, 2022
Closed
@PEZ PEZ merged commit 217e81c into master May 9, 2022
@PEZ PEZ deleted the 36-joyride-panel branch May 9, 2022 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@borkdude borkdude Awaiting requested review from borkdude

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Don't automatically show the Joyride output channel when scripts run
2 participants
@PEZ @borkdude