Skip to content
This repository was archived by the owner on Nov 20, 2024. It is now read-only.

Conversation

@mduong
Copy link

@mduong mduong commented Jun 18, 2020

From flutter#2825

Description

Show the share text in the iOS share preview panel.

Before it just didn't show any preview of the text being shared.

Related Issues

N/A.

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (flutter analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
  • I updated CHANGELOG.md to add a description of the change.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (please indicate a breaking change in CHANGELOG.md and increment major revision).
  • No, this is not a breaking change.

@nanda-prbot
Copy link

@mduong needs to request domain review.
@mduong needs to request platform review, or explicitly opt out, e.g.:

/no-platform

HOW TO: Request Reviewers

@mduong
Copy link
Author

mduong commented Jun 18, 2020

/domain @mseijas @amyslies
/platform @mseijas @samandmoore

@nanda-prbot
Copy link

Needs somebody from @mseijas and @amyslies to claim domain review
Needs somebody from @mseijas and @samandmoore to claim platform review

Use the shovel operator to claim, e.g.:

@myname << domain && platform

HOW TO: Claim a Review

@mduong
Copy link
Author

mduong commented Jun 18, 2020

Matt ran into this issue when testing:
Image from iOS

Here it is with this fix:
image

@mseijas
Copy link

mseijas commented Jun 18, 2020

<< domainLGTM
<< platformLGTM

@nanda-prbot
Copy link

Approved! 💅 🎁 💫

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants