This repository was archived by the owner on Nov 20, 2024. It is now read-only.
Pull in upstream changes to get new Share.shareFiles functionality #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ates. (flutter#2834) * Allow all transactions except for purchasing ones to be passed back to the Flutter side. * Restore transactions shouldn't block transaction updates
* Fix e2e device pixel ratio * Update changelog and version * Formatting
…er#2820) Move the package formerly known as `experimental_connectivity_web` to flutter/plugins master, as `connectivity_for_web`.
Adds shared_preferences support for Linux. Part of flutter/flutter#41720
Expose a `Future` for `testResults` instead. This works better for internal use cases.
Missed this earlier in flutter#2854
This change adds small bugfixes to the following packages: * video_player_web: * Prevent parsing Blob URLs so Safari can play from a PickedFile. * Allow users to 'mute' videos by setting their volume to 0.0 (this enables auto-play in most modern browsers) * video_player: * Fix an issue where aspect ratio calculations failed when some of the video sizes were zero (happened in web for incorrect videos) * image_picker (example app): * Start videos in web muted so they can auto-play * Dispose video controllers when they're really not needed. This fixes a fatal crash in Safari (not so fatal in other browsers).
Adds url_launcher_linux, the federated implementation of url_launcher. Not yet endorsed by url_launcher Part of flutter/flutter#41721
Adds an endorsement for url_launcher_linux, so that Linux is supported automatically. Part of flutter/flutter#41721
Add missing iOS stub to shared_preferences_linux
Endorses shared_preferences_linux. Since shared_preferences_linux is pure Dart, this uses manual registration of the Linux implementation. It is similar to the solution used for path_provider, but improves on it by more narrowly tailoring the registration to cases where another registration hasn't already been done, and only checking the first time, thus avoiding the need for a variable to override it. Updates shared_preferences_linux to depend on path_provider_linux rather than path_provider, to avoid adding unnecessary native plugin dependencies to other platforms. Also adds a driver test for shared_preference_linux, which I missed in reviewing the initial shared_preferences_linux landing.
* Switch to dart:html window.navigator.connection instead of package:js JS-interop. * Overwrite connection.onchange instead of listening to connection.onChange Stream (prevents multiple subscriptions after hot-reload). * Cleaned up old code related to generating the JS facade.
Introduce the first version of the `extension_google_sign_in_as_googleapis_auth` package. This package lets users of the `google_sign_in` plugin to create an authenticated HTTP clients (from `googleapis_auth`) that can access any APIs from the `googleapis` package.
* add extra info report
…port path" (flutter#2896) * Revert "[path_provider] Use the application ID in the application support path (flutter#2845)" This reverts commit 7d4a918. * bump version to satisfy the machine. Also fix linting issue caught because of changes in this folder.
* Make package:e2e a relative reference
…ils (flutter#2866) * [e2e] Fix incorrect test results when one test passes then another fails For example, the following test will result in an error reported for the first test case. ``` void main() { testWidgets('a test that passes', (tester) async { expect(true, true); }); testWidgets('a test that fails', (tester) async { expect(true, false); }); } ``` We need to reset `reportTestException` back to the previous value after completion of `runTest`, or repeated failures will cause the exception handler for a previous test to be invoked, as they "stack". Instead of reseting it, however, do this once in the constructor because the test description is already provided by the function signature. * Add a mechanism for testing test results
* clarify e2e on firebase
…n. (flutter#2903) This change tweaks slightly the core maps plugin and the platform interface package to make the web implementation possible. The most important changes are two: * The core plugin now passes a constant identifier to the buildView platform call, so the web version can cache effectively the contents of the platform view, so it doesn't repaint. This might go away once Scenelets for web come online. * The platform interface now encodes the (optional) width and height of custom Icons for Markers, so the web can render High DPI assets at the correct size. The rest are some examples to the 'example' app so it can be run on web.
…#2908) This method gives the plugin writers a chance to release the resources that they've acquired throughout the operation of the plugin (think of it as an "inverse" of the "init" method).
(To be moved to flutter_test)
…e "XML tag has empty body" (flutter#3288)
* Make sure only camera_platform_interface has updates * add dev dependency to async package * refactored import to package import * Fix formatting issues
* Remove unchecked && deprecated Warnings * Remove settings_aar.gradle * Update CHANGELOG.md * Fix Format * Fix Format * espresso * Format * SuppressWarnings
…lutter#3313) * Expanded platform interface so support setting flash mode * Formatted dart code * Manually serialize flash mode enum rather than relying on stringification. * Add default to flash mode serialization
* Suppress unchecked cast warning in java test * Bumped version number
With NNBD assert(foo != null) for a non nullable foo generates an analysis error. However as long as we support mixed-mode we want these asserts it, so disabling the check.
* Add zoom support to platform interface * Added method to retrieve min supported zoom level * Bumped version to 1.0.2 * Fixed small typo
* code sample fixed * updated CHANGELOG.md and pubspec.yaml
…ter#3309) This is in preparation for dart-lang/http#375
Update Flutter SDK constraint to match templates.
Update Flutter SDK constraint to match templates.
Update Flutter SDK constraint to match templates.
Update Flutter SDK constraint to match templates.
…m-changes * upstream-share-final-null-release: (233 commits) [q-w] Update Flutter SDK constraint (flutter#3323) [i-p] Update Flutter SDK constraint (flutter#3322) [d-g] Update Flutter SDK constraint (flutter#3321) [a-c] Update Flutter SDK constraint (flutter#3320) [image_picker_platform_interface] Pass Uri to package:http APIs (flutter#3309) Exclude null-safe plugins from testing on stable (flutter#3318) [documentation] [url_launcher] fix for readme code sample (flutter#3308) [camera] Add zoom support to platform interface (flutter#3312) update analysis options for nnbd (flutter#3319) [camera] Suppress unchecked cast warning in java test (flutter#3316) [image_picker] [integration_test] Fixes to make the tree green (flutter#3317) [camera] Expanded platform interface to support setting flash mode (flutter#3313) [Espresso] Android Code Inspection and Clean up (flutter#3111) [camera] Add `camera_platform_interface` package (flutter#3253) [camera] Support Android 30 (flutter#3299) bump integration test to 1.0.0 (flutter#3295) [android_alarm_manager] fix AndroidManifest.xml for android lint issue "XML tag has empty body" (flutter#3288) Use testWidgets instead of test to fix failures not surfacing on CI (flutter#3279) [file_selector_platform_interface] Migrate to cross_file package (flutter#3286) Fix broken link (flutter#3280) ...
|
Needs somebody from @achtenhagen, @ClaireDavis, and @mseijas to claim domain review Use the shovel operator to claim, e.g.:
|
|
<< domain |
|
Needs @achtenhagen to provide domain review When you finish a round of review, be sure to say you've finished or sign off on the PR, e.g.:
If you're too busy to review, unclaim the PR, e.g.:
|
|
Needs @achtenhagen to provide domain review When you finish a round of review, be sure to say you've finished or sign off on the PR, e.g.:
If you're too busy to review, unclaim the PR, e.g.:
|
|
<< domain lgtm |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
20 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/domain @achtenhagen @ClaireDavis @mseijas
/no-platform
We need access to the functionality added in this PR flutter#970 but we also need our fixes from this fork #1 #2, so we picked a branch point from flutter/plugins#master that includes those changes but doesn't include the NNBD upgrade for this plugin so that we can keep using our fork until we are done with the flutter 2.x upgrade. That commit is this one: https://github.com/flutter/plugins/tree/0251017cc973924ee40aebf5c2e338c82299f536/packages/share