Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docker CI builds the released version #607

Closed
ivg opened this issue Jan 3, 2017 · 1 comment · Fixed by #615
Closed

Docker CI builds the released version #607

ivg opened this issue Jan 3, 2017 · 1 comment · Fixed by #615
Assignees
@gitoleg
Labels
CI
Milestone
1.2.0

Comments

@ivg
Copy link
Member

ivg commented Jan 3, 2017

Currently, our Docker CI is triggered every merge, but what it builds is the latest release. What we really need, is to build whatever was merged. What I'm suggesting, is to create a new branch in our opam-repository fork, that will build BAP packages directly from the master branch (using the git url, instead of the archive). This will facilitate the release process, as we may be assured that whatever we are realising is actually buildable.

We also, need to have some feedback from dockerhub, that the build was successful (currently one need to go and look at the queue, not very CIish).
@ivg ivg added the CI label Jan 3, 2017
@ivg ivg added this to the 1.2.0 milestone Jan 3, 2017
@ivg ivg mentioned this issue Jan 13, 2017
Merged
@ivg
Copy link
Member Author

ivg commented Jan 17, 2017

Speaking of the integration, we should be able to get a nice DockerHub build status icon (ala the Travis Build status icon) once the badges/shields#856 is merged.

gitoleg added a commit to gitoleg/bap that referenced this issue Jan 18, 2017
@gitoleg
fix BinaryAnalysisPlatform#607
8c30666 
Docker builds last `bap` version, from `master` branch
gitoleg added a commit to gitoleg/bap that referenced this issue Jan 18, 2017
@gitoleg
fix BinaryAnalysisPlatform#607
fac2d64 
Forced Docker to builds last `bap` version, from `master` branch.
@gitoleg gitoleg mentioned this issue Jan 18, 2017
Merged
@ivg ivg closed this as completed in #615 Jan 18, 2017
ivg pushed a commit that referenced this issue Jan 18, 2017
@gitoleg @ivg
fix #607 (#615)
dd9b0e6 
Forced Docker to builds last `bap` version, from `master` branch.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gitoleg gitoleg

Labels
CI
Projects
None yet
Milestone
1.2.0
Development

Successfully merging a pull request may close this issue.

force Docker to build master branch gitoleg/bap
2 participants
@ivg @gitoleg