Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(ui-ux): update warning message when balance is insufficient #841

Merged
merged 6 commits into from
Mar 28, 2023
Merged

chore(ui-ux): update warning message when balance is insufficient #841

merged 6 commits into from
Mar 28, 2023

Conversation

kyleleow
Copy link

@kyleleow kyleleow commented Mar 27, 2023 •
edited
Loading

What this PR does / why we need it:

  • As titled

Which issue(s) does this PR fixes?:

Fixes #733

Additional comments?:

Developer Checklist:

  • Read your code changes at least once
  • No console errors on web
  • Your UI implementation visually matched the rendered design*
  • Unit tests*
  • Added e2e tests*
  • Added translations*

@kyleleow kyleleow self-assigned this Mar 27, 2023
@netlify
Copy link

netlify bot commented Mar 27, 2023 •
edited
Loading

✅ Deploy Preview for quantumbridge ready!

Name Link
🔨 Latest commit a550359
🔍 Latest deploy log https://app.netlify.com/sites/quantumbridge/deploys/64216729ff2cf1000740fe69
😎 Deploy Preview https://deploy-preview-841--quantumbridge.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions github-actions bot added the kind/feature New feature request label Mar 27, 2023
@kyleleow kyleleow changed the base branch from main to 1.9.0 March 27, 2023 09:51
@kyleleow kyleleow changed the title feat(ui-ux): block form when no DFI liquidity while bridging DFI feat(ui-ux): block form when target token has no liquidity Mar 27, 2023
@kyleleow
revert: all previous changes
8f009b4 
Only update warning message when insufficient balance
@kyleleow kyleleow changed the title feat(ui-ux): block form when target token has no liquidity chore(ui-ux): update warning message when balance is insufficient Mar 27, 2023
@github-actions github-actions bot added kind/chore Non feature change and removed kind/feature New feature request labels Mar 27, 2023
@thedoublejay thedoublejay marked this pull request as ready for review March 28, 2023 00:46
@thedoublejay thedoublejay merged commit cbbf652 into 1.9.0 Mar 28, 2023
thedoublejay added a commit that referenced this pull request Mar 29, 2023
@thedoublejay @G9000
@pierregee @kyleleow @fullstackninja864 @lykalabrada @renovate @cuongquangnam @weiyuan95
chore(release): 1.10.0 (#803)
d758573 
* feature(ui-ux): refetch hot wallet balance and transfer guard (#763)

* init

* refactor on transfer token flow

* code cleanup

* code cleanup

* code cleanup -S

* code cleanup

* code cleanup

* resolve pr comment -S

* resolve pr comment

* fix getBalanceFn response type

* code cleanup

---------

Co-authored-by: JJ Adonis <work@josejai.me>
Co-authored-by: Pierre Gee <pierre.gabaldon@gmail.com>

* chore(ops): enable DFI on client (#804)

chore: enable DFI on client

* feature(ui-ux): added liquidity overview screen (#794)

* feature(ui-ux): added liquidity overview screen

* added Link component

* added Disclosure for mobile view

* removed env variables

* removed unused api endpoint

* lint fix

* fixed width in small screen

* renamed router

* added tool tip and added fetch balances on network change

* minor ui updates

* hide navigation when bridge is down

* desc update

* minor fix

* minor updates

* updated hotWalletAddress to HotWalletAddress

* chore: update dfi label on ethereum

Refactor TokenInfo prop and rename component

---------

Co-authored-by: Keng Ye <40191153+kyleleow@users.noreply.github.com>
Co-authored-by: Keng Ye <kengyeleow@gmail.com>

* chore: re-add dfi into client

* feature(ui-ux): added on click event on entire token header bar while closing (#821)

* feature(ui-ux): added test ids for better cypress testing on liquidity screen (#837)

feature(ui-ux): added testids for better cypress testing on liquidity screen

* chore(ui-ux): update warning message when balance is insufficient (#841)

* feat: add reserved utxo on client form

* feat: support all token for liquidity check

* chore: add liquidity as dependency

* revert: all previous changes

Only update warning message when insufficient balance

* chore(ui-ux): claim - prevent txn hook from running on load (#731)

* chore(refactor): claim - prevent txn hook from running on load

* fix(ui-ux): fix lint error

* bump(deps): update dependency react-secure-storage to ^1.2.0 (#839)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* bump(deps): update @waveshq/walletkit to ^0.43.0 (#842)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* bump(deps): update dependency @netlify/plugin-nextjs to ^4.33.0 (#845)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* feat(server): check for hot wallet DFI balance when crafting send tx (#843)

feat: check for hot wallet DFI balance when crafting send tx

* bump(deps): update dependency @fastify/compress to ^6.2.1 (#844)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* feat(server): Add another sanity check for decodeTxnData (#811)

* add another sanity check

* Update apps/server/src/ethereum/services/EVMTransactionConfirmerService.ts

Co-authored-by: Lee Wei Yuan <35588002+weiyuan95@users.noreply.github.com>

---------

Co-authored-by: JJ Adonis <work@josejai.me>
Co-authored-by: Lee Wei Yuan <35588002+weiyuan95@users.noreply.github.com>

* chore(core): add sanity checks in evm to dfc endpoints (#816)

* add another sanity check

* chore(core): add sec checks in evm to dfc endpoints

* use clearer variable names

* remove comment

* check txn validity before accessing db

* pass 0 confirmations and revert name

* rename comments

* rename comments

* revert reodering condition

* fix typo

* update e2e

---------

Co-authored-by: cuongquangnam <tccuong1999@gmail.com>

* fix(ui-ux): fix disabled claim btn (#852)

* fix(ui-ux): trial fix, claim btn is disabled on some machines

* fix(ui-ux): fix disabled claim btn

* fix(ui-ux): fix disabled claim button for eth (#853)

---------

Co-authored-by: Julio Caesar <leo.caesar@live.com>
Co-authored-by: Pierre Gee <pierre.gabaldon@gmail.com>
Co-authored-by: Keng Ye <40191153+kyleleow@users.noreply.github.com>
Co-authored-by: Harsh R <53080940+fullstackninja864@users.noreply.github.com>
Co-authored-by: Keng Ye <kengyeleow@gmail.com>
Co-authored-by: Lyka Labrada <lykalabrada@gmail.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: cuongquangnam <42933311+cuongquangnam@users.noreply.github.com>
Co-authored-by: Lee Wei Yuan <35588002+weiyuan95@users.noreply.github.com>
Co-authored-by: Pierre Gee <pierre@cakedefi.com>
Co-authored-by: cuongquangnam <tccuong1999@gmail.com>
thedoublejay added a commit that referenced this pull request Mar 30, 2023
@fullstackninja864 @G9000
@thedoublejay @pierregee @kyleleow
fix(ui-ux): set default network to mainnet (#865)
d5594f8 
* feature(ui-ux): refetch hot wallet balance and transfer guard (#763)

* init

* refactor on transfer token flow

* code cleanup

* code cleanup

* code cleanup -S

* code cleanup

* code cleanup

* resolve pr comment -S

* resolve pr comment

* fix getBalanceFn response type

* code cleanup

---------

Co-authored-by: JJ Adonis <work@josejai.me>
Co-authored-by: Pierre Gee <pierre.gabaldon@gmail.com>

* chore(ops): enable DFI on client (#804)

chore: enable DFI on client

* feature(ui-ux): added liquidity overview screen (#794)

* feature(ui-ux): added liquidity overview screen

* added Link component

* added Disclosure for mobile view

* removed env variables

* removed unused api endpoint

* lint fix

* fixed width in small screen

* renamed router

* added tool tip and added fetch balances on network change

* minor ui updates

* hide navigation when bridge is down

* desc update

* minor fix

* minor updates

* updated hotWalletAddress to HotWalletAddress

* chore: update dfi label on ethereum

Refactor TokenInfo prop and rename component

---------

Co-authored-by: Keng Ye <40191153+kyleleow@users.noreply.github.com>
Co-authored-by: Keng Ye <kengyeleow@gmail.com>

* chore: re-add dfi into client

* feature(ui-ux): added on click event on entire token header bar while closing (#821)

* feature(ui-ux): added test ids for better cypress testing on liquidity screen (#837)

feature(ui-ux): added testids for better cypress testing on liquidity screen

* chore(ui-ux): update warning message when balance is insufficient (#841)

* feat: add reserved utxo on client form

* feat: support all token for liquidity check

* chore: add liquidity as dependency

* revert: all previous changes

Only update warning message when insufficient balance

* fix(ui-ux): set default network to mainnet

* pr comment fix

---------

Co-authored-by: Julio Caesar <leo.caesar@live.com>
Co-authored-by: JJ Adonis <work@josejai.me>
Co-authored-by: Pierre Gee <pierre.gabaldon@gmail.com>
Co-authored-by: Keng Ye <40191153+kyleleow@users.noreply.github.com>
Co-authored-by: Keng Ye <kengyeleow@gmail.com>
thedoublejay added a commit that referenced this pull request Apr 3, 2023
@fullstackninja864 @kyleleow
@G9000 @thedoublejay @pierregee @lykalabrada @renovate @cuongquangnam @weiyuan95
chore(e2e): add e2e for the liquidity page (#807)
74ecc63 
* feature(ui-ux): added liquidity overview screen

* added Link component

* added Disclosure for mobile view

* removed env variables

* removed unused api endpoint

* lint fix

* fixed width in small screen

* renamed router

* added tool tip and added fetch balances on network change

* feature(ui-ux): refetch hot wallet balance and transfer guard (#763)

* init

* refactor on transfer token flow

* code cleanup

* code cleanup

* code cleanup -S

* code cleanup

* code cleanup

* resolve pr comment -S

* resolve pr comment

* fix getBalanceFn response type

* code cleanup

---------

Co-authored-by: JJ Adonis <work@josejai.me>
Co-authored-by: Pierre Gee <pierre.gabaldon@gmail.com>

* chore(ops): enable DFI on client (#804)

chore: enable DFI on client

* minor ui updates

* hide navigation when bridge is down

* desc update

* minor fix

* minor updates

* updated hotWalletAddress to HotWalletAddress

* added navigation check, PoB link, liquidity validation, addresses checks, basic responsiveness check for mobile elements;

* update port number;

* feature(ui-ux): added liquidity overview screen (#794)

* feature(ui-ux): added liquidity overview screen

* added Link component

* added Disclosure for mobile view

* removed env variables

* removed unused api endpoint

* lint fix

* fixed width in small screen

* renamed router

* added tool tip and added fetch balances on network change

* minor ui updates

* hide navigation when bridge is down

* desc update

* minor fix

* minor updates

* updated hotWalletAddress to HotWalletAddress

* chore: update dfi label on ethereum

Refactor TokenInfo prop and rename component

---------

Co-authored-by: Keng Ye <40191153+kyleleow@users.noreply.github.com>
Co-authored-by: Keng Ye <kengyeleow@gmail.com>

* prettifier;

* Navigation test update;

* chore: re-add dfi into client

* moved navigation check to mobile; add ipad viewport;

* feature(ui-ux): added on click event on entire token header bar while closing (#821)

* prettify;

* feature(ui-ux): added test ids for better cypress testing on liquidity screen (#837)

feature(ui-ux): added testids for better cypress testing on liquidity screen

* chore(ui-ux): update warning message when balance is insufficient (#841)

* feat: add reserved utxo on client form

* feat: support all token for liquidity check

* chore: add liquidity as dependency

* revert: all previous changes

Only update warning message when insufficient balance

* chore(ui-ux): claim - prevent txn hook from running on load (#731)

* chore(refactor): claim - prevent txn hook from running on load

* fix(ui-ux): fix lint error

* bump(deps): update dependency react-secure-storage to ^1.2.0 (#839)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* bump(deps): update @waveshq/walletkit to ^0.43.0 (#842)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* bump(deps): update dependency @netlify/plugin-nextjs to ^4.33.0 (#845)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* feat(server): check for hot wallet DFI balance when crafting send tx (#843)

feat: check for hot wallet DFI balance when crafting send tx

* bump(deps): update dependency @fastify/compress to ^6.2.1 (#844)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* feat(server): Add another sanity check for decodeTxnData (#811)

* add another sanity check

* Update apps/server/src/ethereum/services/EVMTransactionConfirmerService.ts

Co-authored-by: Lee Wei Yuan <35588002+weiyuan95@users.noreply.github.com>

---------

Co-authored-by: JJ Adonis <work@josejai.me>
Co-authored-by: Lee Wei Yuan <35588002+weiyuan95@users.noreply.github.com>

* chore(core): add sanity checks in evm to dfc endpoints (#816)

* add another sanity check

* chore(core): add sec checks in evm to dfc endpoints

* use clearer variable names

* remove comment

* check txn validity before accessing db

* pass 0 confirmations and revert name

* rename comments

* rename comments

* revert reodering condition

* fix typo

* update e2e

---------

Co-authored-by: cuongquangnam <tccuong1999@gmail.com>

* fix(ui-ux): fix disabled claim btn (#852)

* fix(ui-ux): trial fix, claim btn is disabled on some machines

* fix(ui-ux): fix disabled claim btn

* fix(ui-ux): fix disabled claim button for eth (#853)

* add TN/MN liquidity checks; add test ids;

* added testid for navigation check;

* added testid for mobile responsiveness check;

* prettify;

* prettify;

* refactored; add network configs;

* prettify;

* fix lint; rename test ids;gi

* rename testid;

---------

Co-authored-by: Harsh <harshrathi.dev@gmail.com>
Co-authored-by: Keng Ye <40191153+kyleleow@users.noreply.github.com>
Co-authored-by: Julio Caesar <leo.caesar@live.com>
Co-authored-by: JJ Adonis <work@josejai.me>
Co-authored-by: Pierre Gee <pierre.gabaldon@gmail.com>
Co-authored-by: Harsh R <53080940+fullstackninja864@users.noreply.github.com>
Co-authored-by: Keng Ye <kengyeleow@gmail.com>
Co-authored-by: Lyka Labrada <lykalabrada@gmail.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: cuongquangnam <42933311+cuongquangnam@users.noreply.github.com>
Co-authored-by: Lee Wei Yuan <35588002+weiyuan95@users.noreply.github.com>
Co-authored-by: Pierre Gee <pierre@cakedefi.com>
Co-authored-by: cuongquangnam <tccuong1999@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thedoublejay thedoublejay Awaiting requested review from thedoublejay

@fullstackninja864 fullstackninja864 Awaiting requested review from fullstackninja864

@lykalabrada lykalabrada Awaiting requested review from lykalabrada

@pierregee pierregee Awaiting requested review from pierregee

Assignees
No one assigned
Labels
kind/chore Non feature change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Balances - Hot Wallet Liquidity Server - Add 2 DFI as reserved value
2 participants
@kyleleow @thedoublejay