opensearch-project#1506: Remove reservedSymbolTable and use HIDDEN_FI…

…ELD_NAME instead Signed-off-by: acarbonetto <andrewc@bitquilltech.com>
Bit-Quill · Aug 3, 2023 · dd3407e · dd3407e
1 parent bc27060
commit dd3407e
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/core/src/test/java/org/opensearch/sql/analysis/ExpressionAnalyzerTest.java b/core/src/test/java/org/opensearch/sql/analysis/ExpressionAnalyzerTest.java
@@ -234,8 +234,8 @@ public void qualified_name_with_qualifier() {
   public void qualified_name_with_reserved_symbol() {
     analysisContext.push();
 
-    analysisContext.peek().addReservedWord(new Symbol(Namespace.FIELD_NAME, "_reserved"), STRING);
-    analysisContext.peek().addReservedWord(new Symbol(Namespace.FIELD_NAME, "_priority"), FLOAT);
+    analysisContext.peek().define(new Symbol(Namespace.HIDDEN_FIELD_NAME, "_reserved"), STRING);
+    analysisContext.peek().define(new Symbol(Namespace.HIDDEN_FIELD_NAME, "_priority"), FLOAT);
     analysisContext.peek().define(new Symbol(Namespace.INDEX_NAME, "index_alias"), STRUCT);
     assertAnalyzeEqual(
         DSL.ref("_priority", FLOAT),
@@ -246,7 +246,7 @@ public void qualified_name_with_reserved_symbol() {
         qualifiedName("index_alias", "_reserved")
     );
 
-    // reserved fields take priority over symbol table
+    // cannot replace an existing field type
     analysisContext.peek().define(new Symbol(Namespace.FIELD_NAME, "_reserved"), LONG);
     assertAnalyzeEqual(
         DSL.ref("_reserved", STRING),