-
Notifications
You must be signed in to change notification settings - Fork 141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Enhancement] Refactor reservedSymbolTable table. #1506
Labels
maintenance
Improves code quality, but not the product
Comments
6 tasks
dai-chen
added
maintenance
Improves code quality, but not the product
and removed
enhancement
New feature or request
untriaged
labels
Apr 17, 2023
Discussion tracked from #1456 (comment) Should we include _id (and any other available reserved field) on a
|
Go with two abstractions for this, and projectoperator gets only the necessary list from the table. |
acarbonetto
added a commit
to Bit-Quill/opensearch-project-sql
that referenced
this issue
Aug 3, 2023
…ELD_NAME instead Signed-off-by: acarbonetto <andrewc@bitquilltech.com>
acarbonetto
added a commit
to Bit-Quill/opensearch-project-sql
that referenced
this issue
Aug 3, 2023
…ELD_NAME instead Signed-off-by: acarbonetto <andrewc@bitquilltech.com>
6 tasks
acarbonetto
added a commit
to Bit-Quill/opensearch-project-sql
that referenced
this issue
Aug 3, 2023
Signed-off-by: acarbonetto <andrewc@bitquilltech.com>
acarbonetto
added a commit
to Bit-Quill/opensearch-project-sql
that referenced
this issue
Aug 4, 2023
… HIDDEN_FIELD_NAME (#323) * opensearch-project#1506: Remove reservedSymbolTable and use HIDDEN_FIELD_NAME instead Signed-off-by: acarbonetto <andrewc@bitquilltech.com> * opensearch-project#1506: Remove reservedSymbolTable and use HIDDEN_FIELD_NAME instead Signed-off-by: acarbonetto <andrewc@bitquilltech.com> * opensearch-project#1506: Fix checkstyle errors Signed-off-by: acarbonetto <andrewc@bitquilltech.com> --------- Signed-off-by: acarbonetto <andrewc@bitquilltech.com>
6 tasks
acarbonetto
added a commit
to Bit-Quill/opensearch-project-sql
that referenced
this issue
Aug 4, 2023
… HIDDEN_FIELD_NAME (#323) * opensearch-project#1506: Remove reservedSymbolTable and use HIDDEN_FIELD_NAME instead Signed-off-by: acarbonetto <andrewc@bitquilltech.com> * opensearch-project#1506: Remove reservedSymbolTable and use HIDDEN_FIELD_NAME instead Signed-off-by: acarbonetto <andrewc@bitquilltech.com> * opensearch-project#1506: Fix checkstyle errors Signed-off-by: acarbonetto <andrewc@bitquilltech.com> --------- Signed-off-by: acarbonetto <andrewc@bitquilltech.com>
6 tasks
acarbonetto
added a commit
to Bit-Quill/opensearch-project-sql
that referenced
this issue
Aug 14, 2023
Signed-off-by: acarbonetto <andrewc@bitquilltech.com>
acarbonetto
added a commit
that referenced
this issue
Aug 15, 2023
…#1936) * (#1506) Remove reservedSymbolTable and replace with HIDDEN_FIELD_NAME (#323) * #1506: Remove reservedSymbolTable and use HIDDEN_FIELD_NAME instead Signed-off-by: acarbonetto <andrewc@bitquilltech.com> * #1506: Remove reservedSymbolTable and use HIDDEN_FIELD_NAME instead Signed-off-by: acarbonetto <andrewc@bitquilltech.com> * #1506: Fix checkstyle errors Signed-off-by: acarbonetto <andrewc@bitquilltech.com> --------- Signed-off-by: acarbonetto <andrewc@bitquilltech.com> * #1506: spotless apply Signed-off-by: acarbonetto <andrewc@bitquilltech.com> --------- Signed-off-by: acarbonetto <andrewc@bitquilltech.com>
acarbonetto
added a commit
to Bit-Quill/opensearch-project-sql
that referenced
this issue
Aug 15, 2023
… HIDDEN_FIELD_NAME (opensearch-project#1936) * (opensearch-project#1506) Remove reservedSymbolTable and replace with HIDDEN_FIELD_NAME (#323) * opensearch-project#1506: Remove reservedSymbolTable and use HIDDEN_FIELD_NAME instead Signed-off-by: acarbonetto <andrewc@bitquilltech.com> * opensearch-project#1506: Remove reservedSymbolTable and use HIDDEN_FIELD_NAME instead Signed-off-by: acarbonetto <andrewc@bitquilltech.com> * opensearch-project#1506: Fix checkstyle errors Signed-off-by: acarbonetto <andrewc@bitquilltech.com> --------- Signed-off-by: acarbonetto <andrewc@bitquilltech.com> * opensearch-project#1506: spotless apply Signed-off-by: acarbonetto <andrewc@bitquilltech.com> --------- Signed-off-by: acarbonetto <andrewc@bitquilltech.com> (cherry picked from commit 5381a6f) Signed-off-by: acarbonetto <andrewc@bitquilltech.com>
acarbonetto
added a commit
that referenced
this issue
Aug 21, 2023
…#1936) (#1964) * (#1506) Remove reservedSymbolTable and replace with HIDDEN_FIELD_NAME (#323) * #1506: Remove reservedSymbolTable and use HIDDEN_FIELD_NAME instead * #1506: Remove reservedSymbolTable and use HIDDEN_FIELD_NAME instead * #1506: Fix checkstyle errors --------- * #1506: spotless apply --------- (cherry picked from commit 5381a6f) Signed-off-by: acarbonetto <andrewc@bitquilltech.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
In OpenSearch SQL PR #1456, the reservedSymbolTable is used to store reserved symbols, such as _id. We need to explore a better approach to represent reserved symbols and examine the relationship between the reservedSymbolTable and the regular symbol table.
The text was updated successfully, but these errors were encountered: