-
Notifications
You must be signed in to change notification settings - Fork 141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(#1506) Remove reservedSymbolTable and replace with HIDDEN_FIELD_NAME #1936
Merged
acarbonetto
merged 5 commits into
opensearch-project:main
from
Bit-Quill:integ-remove-reservedSymbolTable-1506
Aug 15, 2023
Merged
(#1506) Remove reservedSymbolTable and replace with HIDDEN_FIELD_NAME #1936
acarbonetto
merged 5 commits into
opensearch-project:main
from
Bit-Quill:integ-remove-reservedSymbolTable-1506
Aug 15, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acarbonetto
requested review from
pjfitzgibbons,
ps48,
kavithacm,
derek-ho,
joshuali925,
dai-chen,
YANG-DB,
rupal-bq,
mengweieric,
vmmusings,
Swiddis,
penghuo,
seankao-az,
MaxKsyunz,
Yury-Fridlyand,
anirudha,
forestmvey and
GumpacG
as code owners
August 4, 2023 20:24
… HIDDEN_FIELD_NAME (#323) * opensearch-project#1506: Remove reservedSymbolTable and use HIDDEN_FIELD_NAME instead Signed-off-by: acarbonetto <andrewc@bitquilltech.com> * opensearch-project#1506: Remove reservedSymbolTable and use HIDDEN_FIELD_NAME instead Signed-off-by: acarbonetto <andrewc@bitquilltech.com> * opensearch-project#1506: Fix checkstyle errors Signed-off-by: acarbonetto <andrewc@bitquilltech.com> --------- Signed-off-by: acarbonetto <andrewc@bitquilltech.com>
acarbonetto
force-pushed
the
integ-remove-reservedSymbolTable-1506
branch
from
August 4, 2023 20:28
23c8dd4
to
82aaaa4
Compare
Codecov Report
@@ Coverage Diff @@
## main #1936 +/- ##
============================================
- Coverage 97.51% 97.51% -0.01%
+ Complexity 4657 4656 -1
============================================
Files 408 408
Lines 11933 11930 -3
Branches 829 829
============================================
- Hits 11637 11634 -3
Misses 289 289
Partials 7 7
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Yury-Fridlyand
previously approved these changes
Aug 4, 2023
matthewryanwells
approved these changes
Aug 4, 2023
…edSymbolTable-1506 Signed-off-by: acarbonetto <andrewc@bitquilltech.com>
…edSymbolTable-1506 Signed-off-by: acarbonetto <andrewc@bitquilltech.com>
MitchellGale
approved these changes
Aug 9, 2023
GumpacG
previously approved these changes
Aug 9, 2023
…edSymbolTable-1506 Signed-off-by: acarbonetto <andrewc@bitquilltech.com>
Signed-off-by: acarbonetto <andrewc@bitquilltech.com>
acarbonetto
dismissed stale reviews from GumpacG and Yury-Fridlyand
via
August 14, 2023 17:30
b410e8d
matthewryanwells
approved these changes
Aug 14, 2023
Yury-Fridlyand
approved these changes
Aug 14, 2023
GumpacG
approved these changes
Aug 15, 2023
The backport to
To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/sql/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/sql/backport-2.x
# Create a new branch
git switch --create backport/backport-1936-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 5381a6f76ddc73c0cb14ad5befc444ec68dfdaed
# Push it to GitHub
git push --set-upstream origin backport/backport-1936-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/sql/backport-2.x Then, create a pull request where the |
acarbonetto
added a commit
to Bit-Quill/opensearch-project-sql
that referenced
this pull request
Aug 15, 2023
… HIDDEN_FIELD_NAME (opensearch-project#1936) * (opensearch-project#1506) Remove reservedSymbolTable and replace with HIDDEN_FIELD_NAME (#323) * opensearch-project#1506: Remove reservedSymbolTable and use HIDDEN_FIELD_NAME instead Signed-off-by: acarbonetto <andrewc@bitquilltech.com> * opensearch-project#1506: Remove reservedSymbolTable and use HIDDEN_FIELD_NAME instead Signed-off-by: acarbonetto <andrewc@bitquilltech.com> * opensearch-project#1506: Fix checkstyle errors Signed-off-by: acarbonetto <andrewc@bitquilltech.com> --------- Signed-off-by: acarbonetto <andrewc@bitquilltech.com> * opensearch-project#1506: spotless apply Signed-off-by: acarbonetto <andrewc@bitquilltech.com> --------- Signed-off-by: acarbonetto <andrewc@bitquilltech.com> (cherry picked from commit 5381a6f) Signed-off-by: acarbonetto <andrewc@bitquilltech.com>
6 tasks
acarbonetto
added a commit
that referenced
this pull request
Aug 21, 2023
…#1936) (#1964) * (#1506) Remove reservedSymbolTable and replace with HIDDEN_FIELD_NAME (#323) * #1506: Remove reservedSymbolTable and use HIDDEN_FIELD_NAME instead * #1506: Remove reservedSymbolTable and use HIDDEN_FIELD_NAME instead * #1506: Fix checkstyle errors --------- * #1506: spotless apply --------- (cherry picked from commit 5381a6f) Signed-off-by: acarbonetto <andrewc@bitquilltech.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The reservedSymbolTable was included to separate out fields from hidden fields. It makes more sense to use the HIDDEN_FIELD_NAME namespace instead. Nothing changes for down-stream calls.
Issues Resolved
Fixes #1506
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.