Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address Microsoft feedback #35

Open
wants to merge 35 commits into
base: main
Choose a base branch
from
Open

Address Microsoft feedback #35

Changes from all commits
Commits
Show all changes
35 commits
Select commit Hold shift + click to select a range
040552f
Added Tableau Connector to OpenSearch SQL
Nov 17, 2021
c8ddfb9
Merge pull request #1 from Bit-Quill/migrate-jdbc-tableau-connector
Nov 18, 2021
952ff01
Added CEILING and FLOOR functions
Nov 18, 2021
dd357bc
Merge pull request #2 from Bit-Quill/dialect-ceilfloor-AOS220
Nov 18, 2021
580e1af
Added IFNULL function
Nov 18, 2021
a4d2c0c
Added Kyle's fix for ADDDATE and SUBDATE with resulting 00:00:00 bein…
Nov 18, 2021
10aba05
Added MIN and MAX for two string arguments
Nov 18, 2021
5a90ca7
Merge pull request #3 from Bit-Quill/timestamp-issue
Nov 18, 2021
fa32866
Fixed return type for MID function redefenitions, part of AOS-202
Yury-Fridlyand Nov 19, 2021
b852f9d
Added CAST functions to convert to int or string as part of AOS-202
Yury-Fridlyand Nov 19, 2021
65437b2
Added HEXBINX and HEXBINY functions from the templace without any mod…
Yury-Fridlyand Nov 20, 2021
2e50a43
Fixed cast to use the OSSQL type
Yury-Fridlyand Nov 20, 2021
177d132
Added parenthesis to avoid opensearch-project/sql/issues/293
Yury-Fridlyand Nov 20, 2021
2355abf
Merge pull request #6 from Bit-Quill/dialect-strings-AOS-202-CAST
Yury-Fridlyand Nov 20, 2021
0df001a
Pulled from main from OpenSearch
Nov 22, 2021
8596513
Merge branch 'main' of github.com:Bit-Quill/opensearch-project-sql in…
Nov 22, 2021
f212e35
Modified Timestamp conversion formula
Nov 22, 2021
2df3f26
Merge pull request #8 from Bit-Quill/dialect-expr-logical-AOS205
Nov 23, 2021
7aaf59d
Merge pull request #5 from Bit-Quill/dialect-fix-MID-return-type-AOS-202
Yury-Fridlyand Nov 23, 2021
8d8fa1a
Merge pull request #7 from Bit-Quill/dialect-math.hexbin-AOS-195
Yury-Fridlyand Nov 23, 2021
385a41b
Added comment to TimestampType
Nov 23, 2021
26dbb7e
Updated Company Name accroding to the customer's request
Yury-Fridlyand Nov 23, 2021
3a5271e
Merge pull request #9 from Bit-Quill/update-vendor-AOS-231
Yury-Fridlyand Nov 24, 2021
4c63b64
Updated Vendor Name as well
Yury-Fridlyand Nov 24, 2021
edd2159
Merge pull request #10 from Bit-Quill/update-vendor-AOS-231-part-2
Yury-Fridlyand Nov 25, 2021
07cc2f1
Merge branch 'main' of github.com:opensearch-project/sql into main
Dec 14, 2021
534ddc9
Added TDVT test result and a readme file
Yury-Fridlyand Dec 25, 2021
f88c33b
Merge pull request #25 from Bit-Quill/upload-tdvt-results-AOS-260
Yury-Fridlyand Dec 28, 2021
b10646c
Merge pull request #26 from opensearch-project/main
Yury-Fridlyand Jan 5, 2022
076d068
Merge branch 'opensearch-project:main' into main
Yury-Fridlyand Feb 23, 2022
8b58136
Merge branch 'main' of github.com:opensearch-project/sql into main
Feb 25, 2022
278c05f
Add Certificate Validation option (#31)
Mar 2, 2022
ef5597e
Merge branch 'opensearch-project:main' into main
Yury-Fridlyand Mar 3, 2022
be226a7
Made HostnameVerification opetional and added a default value
Mar 8, 2022
10fd46c
Removed file that was unintentionally added in the last commit
Mar 8, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions bi-connectors/PowerBIConnector/OpenSearchProject.pq
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ OpenSearchProjectType = type function (
Documentation.FieldDescription = "Use SSL",
Documentation.AllowedValues = { true, false }
]),
HostnameVerification as (type logical meta [
optional HostnameVerification as (type logical meta [
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you tested opening PBIDS files generated with the latest connector to see if they work if the optional parameter is not given a value?
There could also be issues with TestConnection as it is expecting HostnameValidation to be set. You need to test with Gateway to confirm.

Documentation.FieldCaption = "Certificate validation",
Documentation.FieldDescription = "Certificate validation",
Documentation.AllowedValues = { true, false }
Expand Down Expand Up @@ -82,7 +82,11 @@ OpenSearchProjectImpl = (Server as text, Port as number, UseSSL as logical, Host
ConnectionString = [
Driver = "OpenSearch SQL ODBC Driver",
Host = FinalServerString,
HostnameVerification = if HostnameVerification then 1 else 0
HostnameVerification =
if HostnameVerification = null or HostnameVerification then
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you can use the ? operator to check for nullity + get the value.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does there need to be a change for PBIDS files to specify this option?

1
else
0
],

SQLGetInfo = Diagnostics.LogValue("SQLGetInfo_Options", [
Expand Down