Skip to content

Remove replace-by-fee extended test #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
deadalnix merged 1 commit into from
May 12, 2017
Merged

Remove replace-by-fee extended test #11

deadalnix merged 1 commit into from
May 12, 2017

Conversation

@ftrader
Copy link
Contributor

@ftrader ftrader commented May 12, 2017

This test seems to have been missed earlier during RBF removal.

@deadalnix
Copy link
Member

deadalnix commented May 12, 2017

How come this test was passing to begin with ?

@ftrader
Copy link
Contributor Author

ftrader commented May 12, 2017 •
edited
Loading

Check e.g. https://travis-ci.org/Bitcoin-ABC/bitcoin-abc/jobs/231479898 (all-green run from last commit).

The test is not run because it is part of the 'extended' regtests, and the standard build does not run those - it does:

qa/pull-tester/rpc-tests.py --coverage

The test was not run because so far we focused on getting the regular tests to pass, and no-one executed the extended tests. It would be good to set up CI for running all tests. Unpaid Travis is not able to handle them (too long).

@deadalnix
Copy link
Member

deadalnix commented May 12, 2017

I see, if it is too long, we don't want to run them on every PR anyway. I'll make sure we have a bot running them on master, and in the meantime, we'll have to do it automanually.

@deadalnix deadalnix merged commit 31fa141 into Bitcoin-ABC:master May 12, 2017
@ftrader ftrader deleted the patch/remove_replace_by_fee_test branch May 13, 2017 08:43
lateminer pushed a commit to lateminer/bitcoin-abc that referenced this pull request Apr 1, 2018
@janko33bd
Merge pull request Bitcoin-ABC#11 from lateminer/dev
61125a2 
Fix errors, parts 6-7
Mengerian pushed a commit to Mengerian/bitcoin-abc that referenced this pull request Oct 31, 2019
@jasonbcox
Add benefits-of-ctor post (Bitcoin-ABC#11)
1ecbcb3
deadalnix pushed a commit that referenced this pull request Dec 28, 2020
@majcosta
[backport#17674] tests: Add initialization order fiasco detection in …
929b492 
…Travis

Summary:
1f9d5af4f197e7cc0469a0bb25dcbc51dfa537f4 tests: Add initialization order fiasco detection in Travis (practicalswift)

Pull request description:

  Add initialization order fiasco detection in Travis :)

  Context: bitcoin/bitcoin#17670 (comment)

  This would have caught the `events_hasher` initialization order issue introduced in #17573  and fixed in #17670.

  Output in case of an initialization order fiasco:

  ```
  ==7934==ERROR: AddressSanitizer: initialization-order-fiasco on address 0x557098d79200 at pc 0x55709796b9a3 bp 0x7ffde524dc30 sp 0x7ffde524dc28
  READ of size 8 at 0x557098d79200 thread T0
      #0 0x55709796b9a2 in CSHA256::Finalize(unsigned char*) src/crypto/sha256.cpp:667:25
      #1 0x5570978150e9 in SeedEvents(CSHA512&) src/random.cpp:462:19
      #2 0x5570978145e1 in SeedSlow(CSHA512&) src/random.cpp:482:5
      #3 0x5570978149a3 in SeedStartup(CSHA512&, (anonymous namespace)::RNGState&) src/random.cpp:527:5
      #4 0x55709781102d in ProcRand(unsigned char*, int, RNGLevel) src/random.cpp:571:9
      #5 0x557097810d19 in GetRandBytes(unsigned char*, int) src/random.cpp:576:59
      #6 0x557096c2f9d5 in (anonymous namespace)::CSignatureCache::CSignatureCache() src/script/sigcache.cpp:34:9
      #7 0x557096511977 in __cxx_global_var_init.7 src/script/sigcache.cpp:67:24
      #8 0x5570965119f8 in _GLOBAL__sub_I_sigcache.cpp src/script/sigcache.cpp
      #9 0x557097bba4ac in __libc_csu_init (src/bitcoind+0x18554ac)
      #10 0x7f214b1c2b27 in __libc_start_main /build/glibc-OTsEL5/glibc-2.27/csu/../csu/libc-start.c:266
      #11 0x5570965347d9 in _start (src/bitcoind+0x1cf7d9)

  0x557098d79200 is located 96 bytes inside of global variable 'events_hasher' defined in 'random.cpp:456:16' (0x557098d791a0) of size 104
    registered at:
      #0 0x557096545dfd in __asan_register_globals compiler-rt/lib/asan/asan_globals.cpp:360:3
      #1 0x557097817f8b in asan.module_ctor (src/bitcoind+0x14b2f8b)

  SUMMARY: AddressSanitizer: initialization-order-fiasco src/crypto/sha256.cpp:667:25 in CSHA256::Finalize(unsigned char*)
  ```

---

Backport of Core [[bitcoin/bitcoin#17674 | PR17674]]

Depends on D8756

Test Plan:
  cmake -GNinja -DCMAKE_C_COMPILER=clang -DCMAKE_CXX_COMPILER=clang++ -DENABLE_SANITIZERS=address
  ninja all check check-functional

Reviewers: #bitcoin_abc, jasonbcox

Reviewed By: #bitcoin_abc, jasonbcox

Differential Revision: https://reviews.bitcoinabc.org/D8757
johann-sys added a commit to johann-sys/bitcoin-abc that referenced this pull request May 15, 2025
@johann-sys
Update COPYING
21b6864 
logoMainnet Explorer
learn more about eCash !
block height/hash, txid, address
Address
ecash:qz60j37wmr0wv2k9ksz5e4qkjdzgxggg3sr98q45ug
Details
JSON
Summary
Script Public Key
76a914b4f947ced8dee62ac5b4054cd41693448321088c88ac
Balance
0
Transactions
2
QR Code
ecash:qz60j37wmr0wv2k9ksz5e4qkjdzgxggg3sr98q45ug
Scripthash
6b7253cd13966210f51a0482486181fb036f639aa1f2fbf6ddd0daee039d4450
Is Valid?
Is Script?
2 Transactions
Newest First
Bitcoin-ABC#2–
0357c59fffffd39cd438db127a39e88887ab818b7b9933db03ba7e44dc73a98f
-552,510.39XEC
6/2, 2014 19:24
(10y, 11mo, 13d ago)
> Input #0 / 0
p2pkhe4a57a901c8d13e411ad47024… #0
(addr:ecash:qz60j37wmr0wv2k9ksz5e4qkjdzgxggg3sr98q45ug
552,510.39XEC
Total Input:
552,510.39XEC
< Output #0 / 1
p2pkh
ecash:qzgyfwdkwn9zx6h9vvl0tafupvk2drkdtg0kzut2al
204,747.39XEC
< Output Bitcoin-ABC#1 / 1
p2pkh
ecash:qzq4es9v7eq2wfm6rxwhpazaryes4xyedsfpjlylcd
347,763XEC
Total Output:
552,510.39XEC
Bitcoin-ABC#1–
e4a57a901c8d13e411ad47024dcba3e04f268c99c6fc1e99f0bf14afc2e81c7f
+552,510.39XEC
5/19, 2014 19:36
(10y, 11mo, 27d ago)
> Input #0 / 18
p2pkh01f5cb95681c922d44ae517da… Bitcoin-ABC#1
(addr:ecash:qqc24zdvcnjhnusda0jkvrrgmkg0jnl88vg4txjsg5
0.01XEC
> Input Bitcoin-ABC#1 / 18
p2pkh6e8f883eb799a9a286fe492a3… #0
(addr:ecash:qr0tjhmsrgjsf3k72xdtqv7flxq750x645z0wwxpmq
40.47XEC
> Input Bitcoin-ABC#2 / 18
p2pkh901bde191beb61d2fc5bf480c… Bitcoin-ABC#1
(addr:ecash:qrjckd8ep6grzchnsv9gcdzwcpwqjazn6unlutuff9
0.01XEC
> Input Bitcoin-ABC#3 / 18
p2pkh8cab265e1896f173757325295… #0
(addr:ecash:qqh24fuuud0yp5pn2q4spdh8yfwd8kskzyhtmgu8c6
53,927.28XEC
> Input Bitcoin-ABC#4 / 18
p2pkhbb79adc9ad5e696ed8fe08f74… Bitcoin-ABC#1
(addr:ecash:qqe3egddd4s95glp0kczh02evv3q326pvq9r25j3jn
0.01XEC
> Input Bitcoin-ABC#5 / 18
p2pkh4dacaefb3d43daed074189358… Bitcoin-ABC#1
(addr:ecash:qrrdyutsjnr5xy7fd60dgra9aw8jc5gjdy00exz55l
0.01XEC
> Input Bitcoin-ABC#6 / 18
p2pkh65f5d4d7b80e0cd4d4d477b65… Bitcoin-ABC#1
(addr:ecash:qrgs5rvlxee0f4cayf9tcslzdn3h7kky95jvyljnqq
0.01XEC
> Input Bitcoin-ABC#7 / 18
p2pkhf183d53245ab3a17a3278e696… #0
(addr:ecash:qrjckd8ep6grzchnsv9gcdzwcpwqjazn6unlutuff9
9,438XEC
> Input Bitcoin-ABC#8 / 18
p2pkh7f6ce8e4e912b8da7da9f43ac… Bitcoin-ABC#1
(addr:ecash:qzzy34srdrgtnzqcy3adgcxh278x78mwmuya540hkx
0.01XEC
> Input Bitcoin-ABC#9 / 18
p2pkh3922dd199e8901bc7dffc06fe… #0
(addr:ecash:qpycut36dx0j03us0c4l3hn9cfhyclu9e5nxxhz3dg
0.01XEC
> Input Bitcoin-ABC#10 / 18
p2pkhd00af226755d2f6f78c3c213d… Bitcoin-ABC#1
(addr:ecash:qpnyhed8vzp34mtg63cxxy6cdjcsdcnazsff2sylqt
0.01XEC
> Input Bitcoin-ABC#11 / 18
p2pkha04e516237bc80d3716a174e0… #0
(addr:ecash:qptuamelkkux8r5uuv8uqlzmn0ag2542fydyslz7s5
399,970XEC
> Input Bitcoin-ABC#12 / 18
p2pkhd63ccab1d9b1fe1788d21d38b… Bitcoin-ABC#1
(addr:ecash:qryd3ex3zq860sqzney5guqlf5r2y8huzcy0ng8uuv
5.13XEC
> Input Bitcoin-ABC#13 / 18
p2pkh0fe15b8cc74cfd189ca866132… Bitcoin-ABC#16
(addr:ecash:qrjckd8ep6grzchnsv9gcdzwcpwqjazn6unlutuff9
80XEC
> Input Bitcoin-ABC#14 / 18
p2pkh679fde36f4059292df243e074… Bitcoin-ABC#1
(addr:ecash:qzuch5gavmtnl7ql53xhswquhu8jz6p7z5jfej3nam
0.01XEC
> Input Bitcoin-ABC#15 / 18
p2pkha2a641d13a94a3dcc77cacaa8… Bitcoin-ABC#6
(addr:ecash:qrjckd8ep6grzchnsv9gcdzwcpwqjazn6unlutuff9
400XEC
> Input Bitcoin-ABC#16 / 18
p2pkh46f3140ef52750b7c380e8f91… Bitcoin-ABC#200
(addr:ecash:qrjckd8ep6grzchnsv9gcdzwcpwqjazn6unlutuff9
20.68XEC
> Input Bitcoin-ABC#17 / 18
p2pkhafa535d4b4e2345cf7fce38f9… Bitcoin-ABC#46
(addr:ecash:qrjckd8ep6grzchnsv9gcdzwcpwqjazn6unlutuff9
96.45XEC
> Input Bitcoin-ABC#18 / 18
p2pkh6ab5f652b42b27703f5c1fc34… Bitcoin-ABC#1
(addr:ecash:qzrn4d90fw6029pmdn95r5wy68z4638luyv5rnl303
88,932.29XEC
Total Input:
552,910.39XEC
< Output #0 / 0
p2pkh
ecash:qz60j37wmr0wv2k9ksz5e4qkjdzgxggg3sr98q45ug
552,510.39XEC
Total Output:
552,510.39XEC
hosted by bitcoinabc.org
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ftrader @deadalnix