Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MiniCart fix for m2.1.9 #115

Merged
merged 4 commits into from
Sep 20, 2018
Merged

MiniCart fix for m2.1.9 #115

merged 4 commits into from
Sep 20, 2018

Conversation

YevhenShBolt
Copy link
Contributor

Fix the problem when Mini cart not cleared after user place orders.

It was affected Magento till version 2.2.0

@daisy1754
Copy link
Contributor

@YevhenShBolt if you can add more comments (+maybe link to bug on magento2 github) in PR comments and in source code comment regarding what is issue and how we workaround, that'd be great.

@YevhenShBolt
Copy link
Contributor Author

YevhenShBolt commented Sep 20, 2018

@daisy1754
Magento Issue: magento/magento2#12504
Fix: magento/magento2@9093ce9

But we should not use customerData.reload(sections, true); - it cause additional js error.

Copy link
Contributor

@danac-gs danac-gs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@daisy1754 daisy1754 merged commit 7fe70b0 into develop Sep 20, 2018
@daisy1754 daisy1754 deleted the minicart_fix_for_M2.1.9 branch September 20, 2018 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants