-
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove the "ancient PC" optimization #209
Conversation
I am just curious @touwys, this PR removes the "ancient PC optimization", are you able repeat the same test? Reviewing this PR has no priority at all. Expected result: it may take a little longer to find the best matches. |
ba2736d
to
6affbe8
Compare
Yes, I am. Can take care of it on Tuesday, 26th. |
@Borewit : listFix()-2.8.1-5The ancient pc speed test could not be brought to a successful conclusion, due to an issue that repeatedly broke the repair process. Namely, the repair process stopped immediately after having first completed finding the exact matches. Finding the exact matches was therefore not naturally followed by the next part of the process, i.e. finding the closest matches. There were no other visible clues to this occurrence, but the stop. Nevertheless, the test was completed using the identical setup as before, and inasmuch as it concerns testing the speed of finding only the exact matches. Setup
ResultsTest 1
Test 2
Comments & Questions
|
So sorry, made a mistake in the cancellation logic. I took it out, as it not necessary check with within processing a single playlist entry, per playlist entry is good enough. I overwrote the last commit, hence you get again a build with the same version number. |
6affbe8
to
b10ea22
Compare
Do you want me to repeat the ancient of speed test with build? Anything else perhaps, that I should check for? Can do it Wed. 27th. |
I would be interesting to know the difference in performance between the previous optimization and this one. The build reflect the state before this PR can be found here: https://github.com/Borewit/listFix/actions/runs/6302944637 Please note that in the log file you can find the time it took to process the resolve the closest matches, e.g.: Resolved closest matches in 38 ms. But it way more important that I did not break anything! |
I can do this tomorrow, no problem at all. Is it alright if I go back and forth between the two builds, when installing the one over the other all the time? |
Thanks, and there I was using a stopwatch all this time. 😆 |
I admire your commitment! |
It's mutual. 👍🏻 |
@Borewit : I'm unable to locate those "logfile.log" files again... did the name, or location, perhaps change at all? Not desperately searching for it, though, as I'm able to carry on as before without it. |
@Borewit : There appears to be an issue with the package installer for this build. When the installation is executed, there is a momentary flash of a process-dialogue across the screen, but the installation nothing carry on to complete: 9-27-2023.09-07-49.mp4 |
No change, should be in: I will add a section to the README to cover that. |
I don't think it is the build. It works for me, and we are building the deployment in the pipeline which gives a very consistent result. Try to uninstall, restart computer. On the quality of the installer itself I have very little influence. Update: but I did have similar issue testing a different deployment with the same version number. Let me investigate if that can be improved. |
Thanks, I was on the verge of doing just that, when a scheduled power blackout hit.
Will try again tomorrow after receiving the results of your investigation. |
For me uninstalling ListFix() was enough. I also just merged #210 which an update of a component which has some influence on the build process. |
Thanks, I was peeking in the wrong directory i.e. %appdata%. However, using the stopwatch is fun! |
I will do that next when I'm at the PC then, and not wait for the outcome of your checking over of the build/installer. I was not too surprised at the trouble during the installation, because I've observed in the past that Windows does not like the crisscross installation of older and newer app versions. |
2023.09.28 This installation failed, too. Same symptoms. The following measures were taken before attempting the installation this time:
|
Not sure whether I was supposed to download this build listFix()-2.8.1.8, but I did, and these are the results:
ResultsTest 1: listFix()-2.8.1-4
Test 2: listFix()-2.8.1-8
Comments
Additional Information:
1.1 "history" — content: 1.2 "medialibrary" — not seen, notepad hung. 1.3 "options" — content 2. Another strange issue is observable while re-adding a directory to the Media Directories pane: Steps: 2.1 Add a mp3 and afterwards a flac directory to the Media Directories pane. |
Removes the ["ancient PC optimization"] and replaces it with a much short lambda expression.