Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove multi-list closest-match repair #214

Merged
merged 1 commit into from
Oct 5, 2023
Merged

Conversation

Borewit
Copy link
Owner

@Borewit Borewit commented Oct 3, 2023

Resolves #207

@Borewit Borewit self-assigned this Oct 3, 2023
@Borewit Borewit force-pushed the remove-closest-match-repair branch from 6a2c398 to b8e0c82 Compare October 4, 2023 17:11
Repository owner deleted a comment from github-actions bot Oct 4, 2023
@github-actions
Copy link

github-actions bot commented Oct 4, 2023

@Borewit
Copy link
Owner Author

Borewit commented Oct 4, 2023

Happy with this change @touwys?

@touwys
Copy link

touwys commented Oct 5, 2023

listFix()-2.8.1-14-057b1ce

Review the renegade (deep, batch) repair function #207

👉🏻 Resolved.


Additional observations:

  1. Build-number added:

    image

  2. For interest's sake, I also ran the repair speed tests again, using the same playlist with 631 broken tracks, as before:

    Test 1: For this test, the FLAC plus MP3 Media Directories were added as media sources.
    Test 2: For this test, the FLAC directory is removed, leaving the MP3 directory as the only media source.

    REPAIR ACTION Test 1: FLAC+MP3 Test 2: MP3 ONLY
    Find Exact Matches 1m 09s 0m 29s
    Find Closest Matches 5m 17s 2m 42s
    Find All Matches 6m 26s 3m 11s

    Notably, the aforegoing test results have grown worse by a considerable margin (>30%), over those of previous builds — all which were nearly consistent.

  3. In addition, and this is a purely circumstantial observation, the PC memory (16GB RAM in this instance) usage appears to have worsened, too, while the playlist repair was in progress. Mouse pointer movement became rough/sticky/bumpy, unresponsive, and it is best to wait until all the broken track matches are found before continuing to multitask.


@Borewit
Copy link
Owner Author

Borewit commented Oct 5, 2023

Notably, the aforegoing test results have grown worse by a considerable margin (>30%), over those of previous builds — all which were nearly consistent.

The only explanation I have is that this is the effect of #209, but that you have not been able to measure that correctly because you experiences issue installing the corresponding build. I opened PR #207, which reverse the changes of #209.

@Borewit Borewit merged commit a620bc8 into main Oct 5, 2023
4 checks passed
@Borewit Borewit deleted the remove-closest-match-repair branch October 23, 2023 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Review the renegade (deep, batch) repair function
2 participants