-
-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Some ID3v2.3 native tag names contain null byte #795
Comments
I do, thanks @bradisbell ! |
This id3v2 header is violating the standard. The id3v2.3 Frame ID:
Furthermore, unless declared experimental, the tag ID's are preserved by the id3 standard. So What fails in this scenario is that music-metadata should generate a warning an invalid frame ID has been found. |
Thanks for looking into that, and adding the warning! I decided to do some digging into the sample files I have to find commonalities in case anyone else hits this issue. It looks like Apple products were creating these invalid tags. Here are some of the version numbers I've noticed: iTunes
GarageBand
Logic Pro
|
When iterating through
metadata.native['ID3V2.3']
, I've noticed that some tag names contain a null byte at the end:TP1
TP2
TAL
TEN
(If you serialize the tag names to JSON, you'll see
TP1\u0000
,TP2\u0000
, etc.)Attached is a test file that demonstrates the problem. Please let me know if you'd like any other test files! In the mean time, I'm going to work around this by trimming the tag names, but I figured you would want the test case. Thanks!
bc5f5386-82ae-4f86-b5f5-61000d8fa381.zip
The text was updated successfully, but these errors were encountered: