Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve warning regarding invalid ID3v3 frame ID's #796

Merged
merged 2 commits into from
Apr 18, 2021
Merged

Improve warning regarding invalid ID3v3 frame ID's #796

merged 2 commits into from
Apr 18, 2021

Conversation

Borewit
Copy link
Owner

@Borewit Borewit commented Apr 18, 2021 •
edited
Loading

Related to #795

Changes:

  • Fix flaky ID3v2 frame ID syntax check
    • ID3v2.2: validate frame ID with regexp /[A-Z0-9]{3}/g
    • ID3v2.3, ID3v2.4: validate frame ID with regexp /[A-Z0-9]{4}/g
  • Keep processing tags, even after corrupt ID's have been found
  • Add unit test handling ID32.2 tag ID's in ID32.3 header

@Borewit Borewit self-assigned this Apr 18, 2021
@Borewit Borewit linked an issue Apr 18, 2021 that may be closed by this pull request
Some ID3v2.3 native tag names contain null byte #795
Closed
@Borewit Borewit merged commit 59c51a3 into master Apr 18, 2021
@Borewit Borewit deleted the improve-id3v2-id-warnings branch April 18, 2021 11:07
@Borewit
Copy link
Owner Author

Borewit commented Apr 21, 2021

Part of v7.8.4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Borewit Borewit

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Some ID3v2.3 native tag names contain null byte
1 participant
@Borewit