Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add ability to convert vehicle loadouts into crates #539

Merged
merged 4 commits into from
Sep 20, 2024
Merged

add ability to convert vehicle loadouts into crates #539

merged 4 commits into from
Sep 20, 2024

Conversation

TheCandianVendingMachine
Copy link
Contributor

@TheCandianVendingMachine TheCandianVendingMachine commented Sep 6, 2024 •
edited
Loading

requested by kilo, vehicle loadouts will automatically be added into ACE cargo as ammo boxes with appropiate number of equipment

https://youtu.be/1A0rzEVLtgg?si=5lEhtpDXDP2Y1sAG

This was referenced Sep 9, 2024
Merged
Merged
lambdatiger
lambdatiger reviewed Sep 10, 2024
View reviewed changes
Copy link
Contributor

@lambdatiger lambdatiger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the greedy algorithm here, it's messy in a way that makes it feel like you could throw it in boxes but you didn't have the time to sort it all out.

@TheCandianVendingMachine
Copy link
Contributor Author

Moved greedy fill to function so behaviour is the same. Moved to dedicated file due to length

lambdatiger
lambdatiger approved these changes Sep 11, 2024
View reviewed changes
Copy link
Contributor

@lambdatiger lambdatiger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@PabstMirror PabstMirror added this to the v1.3.45 milestone Sep 11, 2024
@PabstMirror PabstMirror merged commit d3bafa8 into master Sep 20, 2024
1 check passed
@PabstMirror PabstMirror deleted the resupply_as_boxes branch September 20, 2024 02:33
@lambdatiger lambdatiger mentioned this pull request Sep 21, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lambdatiger lambdatiger lambdatiger approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.3.45
Development

Successfully merging this pull request may close these issues.
3 participants
@TheCandianVendingMachine @lambdatiger @PabstMirror