Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump Magick.NET-Q8-AnyCPU from 13.6.0 to 13.7.0 in /Google.Authenticator.Tests #213

Closed
wants to merge 1 commit into from
Closed

Bump Magick.NET-Q8-AnyCPU from 13.6.0 to 13.7.0 in /Google.Authenticator.Tests #213

wants to merge 1 commit into from

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Apr 29, 2024

Bumps Magick.NET-Q8-AnyCPU from 13.6.0 to 13.7.0.

Release notes

Sourced from Magick.NET-Q8-AnyCPU's releases.

Magick.NET 13.7.0

Changes in Magick.NET:

Related changes in ImageMagick since the last release of Magick.NET:

Library updates:

  • ImageMagick 7.1.1-32 beta (2024-04-23)
  • aom 3.8.2 (2024-03-13)
  • imath 3.1.11 (2024-02-29)
  • openexr 3.2.3 (2024-03-07)
  • ffi 3.4.6 (2024-02-18)
  • harfbuzz 8.3.1 (2024-03-17)
  • highway 1.1.0 (2024-02-18)
  • jpeg-xl 0.10.2 (2024-03-08)
  • openjpeg 2.5.2 (2024-02-28)

... (truncated)

Commits
  • 32edbce Published Magick.NET 13.7.0
  • 3004fb6 Fix for 32bit build.
  • 433c971 Removed unused using.
  • 7451e55 Added MaxProfileSize to the ResourceLimits.
  • 3ed7a34 Updated Magick.Native.
  • ba728d4 Updated Magick.Native.
  • 1634834 Corrected class name.
  • 58b24c8 Added ThrowsAttribute and implement this for MaxMemoryRequest.
  • 8c32fb9 Renamed class for property info and moved other helper class to new folder.
  • e8973f6 Use wildcard for the EmbeddedResource instead.
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot
Bump Magick.NET-Q8-AnyCPU in /Google.Authenticator.Tests
9ae55ca 
Bumps [Magick.NET-Q8-AnyCPU](https://github.com/dlemstra/Magick.NET) from 13.6.0 to 13.7.0.
- [Release notes](https://github.com/dlemstra/Magick.NET/releases)
- [Commits](dlemstra/Magick.NET@13.6.0...13.7.0)

---
updated-dependencies:
- dependency-name: Magick.NET-Q8-AnyCPU
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot added the dependencies Pull requests that update a dependency file label Apr 29, 2024
@ahwm
Copy link
Collaborator

ahwm commented May 3, 2024 •
edited
Loading

@flytzen want to take a look? I'm not totally clear on the stack trace, but it looks like ImageMagick is throwing an exception. Think it's related to our usage?

ImageMagick.MagickMissingDelegateErrorException : no encode delegate for this image format `GRADIENT' @ error/constitute.c/WriteImage/1409
   at ImageMagick.MagickExceptionHelper.Check(IntPtr exception) in /_/src/Magick.NET/Exceptions/MagickExceptionHelper.cs:line 18
   at ImageMagick.NativeHelper.CheckException(IntPtr exception) in /_/src/Magick.NET/Native/NativeHelper.cs:line 27
   at ImageMagick.MagickImage.NativeMagickImage.WriteStream(IMagickSettings`1 settings, ReadWriteStreamDelegate writer, SeekStreamDelegate seeker, TellStreamDelegate teller, ReadWriteStreamDelegate reader) in /_/src/Magick.NET/Native/MagickImage.cs:line 8683
   at ImageMagick.MagickImage.ToByteArray() in /_/src/Magick.NET/MagickImage.cs:line 6516
   at ImageMagick.MagickImage.ToByteArray(MagickFormat format) in /_/src/Magick.NET/MagickImage.cs:line 6544
   at ZXing.Magick.MagickImageLuminanceSource.CalculateLuminance(IMagickImage src)
   at ZXing.Magick.MagickImageLuminanceSource..ctor(IMagickImage image)
   at Google.Authenticator.Tests.QRCodeTest.ExtractUrlFromQRImage(String qrCodeSetupImageUrl) in D:\a\1\s\Google.Authenticator.Tests\QRCodeTest.cs:line 81

Magick.NET 13.7.0 updated to a beta version of ImageMagick and I'm wondering if that might have something to do with it.

https://github.com/dlemstra/Magick.NET/releases/tag/13.7.0

@flytzen
Copy link
Collaborator

flytzen commented May 3, 2024

Yeah, I'll have a look 👍
As I recall, there is something a little bit cobbled together here due to the different frameworks 😃
I'm away for a couple of days but will pick up when I'm back.

@flytzen flytzen self-assigned this May 7, 2024
@flytzen
Copy link
Collaborator

flytzen commented May 9, 2024

@ahwm Wow, that was ... interesting,
TL;DR; Don't upgrade!

Okay, so here is the problem:
ZXIng,Magick has a dependency on Magick.Net.Core v 12.3.0.

Magick.Net.Core is not enough - it basically just has interfaces in it. So we take a dependency on Magick.NET-Q8-AnyCPU, which itself has a dependency on Magick.Net.Core. We therefore consume v 13.6.0 or 13.7.0 of Magick.Net.Core, which quietly replaces the v 12.3.0 that Magick.Net.Core depends on.

Until 13.7.0 that was never a problem. However, Magick.Net.Core has an enum called MagickFormat. This enum does not have explicit values.
There is a call to MagickImage.ToByteArray(MagickFormat.Gray) inside of ZXing.
MagickFormat.Gray has a value of 83 in v 13.6.0 and that is hardcoded in to ZXing. However, with Magick.Net 13.7, 83 = Gradient hence the error.

This was referenced May 9, 2024
Closed
Closed
@ahwm
Copy link
Collaborator

ahwm commented May 9, 2024

Wow. That does sound interesting. Closing this PR, then. Dang. 😂

@ahwm ahwm closed this May 9, 2024
@dependabot Dependabot
Copy link
Contributor Author

dependabot bot commented on behalf of github May 9, 2024

OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting @dependabot ignore this major version or @dependabot ignore this minor version. You can also ignore all major, minor, or patch releases for a dependency by adding an ignore condition with the desired update_types to your config file.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.

@ahwm ahwm deleted the dependabot/nuget/Google.Authenticator.Tests/Magick.NET-Q8-AnyCPU-13.7.0 branch May 9, 2024 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@flytzen flytzen

Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ahwm @flytzen