-
-
Notifications
You must be signed in to change notification settings - Fork 419
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MagicFormat enum values change in 13.7.0 #1627
Comments
I don't know if version |
Transient dependencies are a pain :) Thank you so much. |
I don't want to assign them values that might make someone assume that the values have meaning. |
Magick.NET version
13.7.0
Environment (Operating system, version and so on)
Any
Description
The enum
Magick.Format
had a new value added in 13.7.0.This can cause problems with nested dependencies and lead to an exception being thrown.
Specifically:
Steps to Reproduce
ZXing is a library with bindings to a lot of image processors, including Magick. The
ZXing.Magick
binding specifically referencesMagick.Net.Core
12.3.0.It has a line which specifically references
MagickFormat.Gray
. In v13.6.0 and before, that was83
. However, in 13.7.0,83
isGradient
.Consumers of ZXing have to make an explicit reference to
Magick.Net
asMagick.Net.Core
is not enough on its own. That, then, leads to Dependabot wanting to upgrade that reference to the latest, which then breaksZXing
. Once a consumer of ZXing upgrades Magick.Net to 13.7.0, they will start getting exceptions aboutGradient
not being supported. This is becauseZXing
continues to pass in83
toMagick.Net
- but the meaning of that has changed.The
GoogleAuthenticator
library I work on has run in to this: BrandonPotter/GoogleAuthenticator#213ZXing
can of course be upgraded but that may cause other issues.You may or may not feel this is an issue in Magick.Net - I can see both arguments. I can see one way of resolving it in Magick.Net, which would be to explicitly assign integers to the
Magick.Format
enum - but that does risk breaking consumers of 13.7 :(The text was updated successfully, but these errors were encountered: