-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pyautoscoper type validator #183
base: main
Are you sure you want to change the base?
Pyautoscoper type validator #183
Conversation
NicerNewerCar
commented
Aug 2, 2023
- Closes Improve robustness of PyAutoscoper introducing validator #171
- Introduces validator classes to validate types within PyAutoscoper before sending them off to the Autoscoper server
- Introduces unit tests for the validators and enum types
Before adding validation, I suggest to add the missing annotation types by fixing the errors reported after enabling the |
76657de
to
d31db78
Compare
See #192 |
d31db78
to
b99a31b
Compare
b99a31b
to
d03c892
Compare
Relevant documentation:
|
We should also look into It seems like we could specify custom types as annotation and have these used at runtime when the function is called. Also relevant:
|
* Allows the use of 'magic values' in comparisons within the test directory
@jcfr The only errors in ruff now are a couple of Autoscoper/scripts/python/PyAutoscoper/validators.py Lines 8 to 24 in 7513ea9
|