Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Ruff settings enaling flake8-annotations rules #192

Merged
merged 3 commits into from
Aug 9, 2023

Conversation

NicerNewerCar
Copy link
Contributor

@NicerNewerCar NicerNewerCar commented Aug 8, 2023

This pull request was created following #183 (comment)

Summary:

  • Enables the flake8-annotations and flake8-future-annotations rules
  • Updates PyAutoscoper to have type annotations.

Note that to support Python 3.8, it is required to add from __future__ import annotations

References:

@NicerNewerCar NicerNewerCar requested a review from jcfr August 8, 2023 14:39
@jcfr jcfr force-pushed the flake8-annotations branch from 7cf2213 to 9a3eca9 Compare August 9, 2023 20:22
@jcfr jcfr changed the title Flake8 annotations Update Ruff settings enaling flake8-annotations rules Aug 9, 2023
NicerNewerCar and others added 3 commits August 9, 2023 16:53
Fix use with Python 3.8 adding `from __future__ import annotations`.

See https://docs.python.org/3/library/__future__.html

Co-authored-by: Jean-Christophe Fillion-Robin <jchris.fillionr@kitware.com>
Co-authored-by: Anthony Lombardi <anthony.lombardi@kitware.com>
@jcfr jcfr force-pushed the flake8-annotations branch from 9a3eca9 to 76962d1 Compare August 9, 2023 20:55
@jcfr jcfr merged commit e7da3c4 into BrownBiomechanics:main Aug 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants