Update localtunnel package to fix a vulnerable dependency - fixes #1695 #1697
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hugovk
approved these changes
Jun 3, 2019
| @@ -48,7 +48,7 @@ | |||
| "fs-extra": "3.0.1", | |||
| "http-proxy": "1.15.2", | |||
| "immutable": "^3", | |||
| "localtunnel": "1.9.1", | |||
| "localtunnel": "1.9.2", | |||
There was a problem hiding this comment.
Suggested change
| "localtunnel": "1.9.2", | |
| "localtunnel": "^1.9.2", |
How about adding a caret range? This would allow >=1.9.2 <2.0.0.
https://yarnpkg.com/en/docs/dependency-versions#toc-caret-ranges
In any case, would be great to get this security issue released as soon as possible, pinned or careted.
Thanks!
There was a problem hiding this comment.
If the maintainer(s) are okay with this change it sounds reasonable. What say @shakyShane ?
|
@gaards please merge. |
udithishara
approved these changes
Jun 6, 2019
leicht-io
approved these changes
Jun 7, 2019
shakyShane
changed the title
|
released in browser-sync@2.26.7 - thank you :) |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the localtunnel package to the latest version that includes an updated version of the axios package (which contained a security vulnerability).
Related issue
#1695