Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update package-lock.json to fix axios vulnerability #1467

Closed
wants to merge 1 commit into from

Conversation

saad-mo
Copy link
Contributor

@saad-mo saad-mo commented May 31, 2019

Updated package-lock.json as suggested by the security alert - https://github.com/SAP/fundamental/network/alert/package-lock.json/axios/open

@saad-mo saad-mo requested review from greg-a-smith and jbadan May 31, 2019 15:47
@netlify
Copy link

netlify bot commented May 31, 2019

Deploy preview for fundamental ready!

Built with commit 262f213

https://deploy-preview-1467--fundamental.netlify.com

@greg-a-smith
Copy link
Contributor

@saad-mo How did this file get updated? Was it manually edited? Was it re-running npm install? Was the file deleted and then regenerated with npm install? Typically, this file shouldn't change unless there is a change in package.json.

@jbadan
Copy link
Contributor

jbadan commented Jun 3, 2019

@greg-a-smith and @saad-mo
These need to be merged and released before we can fix the problem in our repo: BrowserSync/browser-sync#1697
github-tools/github#565

then update github-assistant with new github-api, release, update all fundamental-* packages.

@j-rewerts
Copy link

GitHub tools has released version 3.2.2 with this vulnerability fixed.

@jbadan
Copy link
Contributor

jbadan commented Jun 18, 2019

@j-rewerts Thanks for following up! Feel free to open a pr :)

@droshev droshev deleted the fix/axios-vulnerability branch February 21, 2023 23:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants