Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

notifications: Try to guess app id if getting from hints fails #479

Merged
merged 2 commits into from
Oct 18, 2023
Merged

notifications: Try to guess app id if getting from hints fails #479

merged 2 commits into from
Oct 18, 2023

Commits on Oct 16, 2023

  1. notifications: Try to guess app id if getting from hints fails 

    The notification spec states that the `desktop-entry` hint should be the prefix of the Desktop Application Info file. However, because of the push to have fully-qualified app ID's, some applications now have a mismatch between the ID and the desktop file, meaning the hint cannot be used for that application.

In cases where the hint fails, try to guess the ID using the application's name given to us from DBus.

It seems to fix #477.

Signed-off-by: Evan Maddock <maddock.evan@vivaldi.net>
    @EbonJaeger
    EbonJaeger committed Oct 16, 2023
    Configuration menu
    Copy the full SHA
    b4fb60d View commit details
    Browse the repository at this point in the history

  2. notifications: Fix icon fallback when DesktopAppInfo is null 

    Signed-off-by: Evan Maddock <maddock.evan@vivaldi.net>
    @EbonJaeger
    EbonJaeger committed Oct 16, 2023
    Configuration menu
    Copy the full SHA
    1eb013c View commit details
    Browse the repository at this point in the history