-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chore - use pro as submodule #10267
Merged
Merged
Chore - use pro as submodule #10267
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rory-Powell
reviewed
Apr 11, 2023
Rory-Powell
reviewed
Apr 11, 2023
Rory-Powell
reviewed
Apr 11, 2023
Rory-Powell
reviewed
Apr 11, 2023
Rory-Powell
reviewed
Apr 11, 2023
Rory-Powell
reviewed
Apr 11, 2023
Rory-Powell
reviewed
Apr 11, 2023
Rory-Powell
reviewed
Apr 11, 2023
Rory-Powell
reviewed
Apr 19, 2023
Rory-Powell
approved these changes
Apr 19, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR changes the way we interact with budibase-pro. Instead of being an independent repository published via npm or consumed via yarn links, now the pro will be treated as any other package in the budibase monorepo. The main difference is that this code lives in a different repo, as it's private code, but consuming it as a submodule, it will act as any other existing package.
Doing so we have the benefits of having all the packages together, and using properly build tools such as nx and esbuild, and dev tools such as proper debugging and hot reloading.
The main changes in this PR are:
packages/pro
bootstrap
to link properly the pro package foraccount-portal
references
in thetsconfig.json
files, as now they are not required anymore. Nx handles these dependencies for us, so we don't need to worry. This has a benefit in that we don't need to check if we have pro loaded or not.Contributor experience
What happens to open source contributors or developers that have the module not loaded?
Nothing, for them the experience will be the same as it is now. When we run
yarn install
, the workspace will detect that the package does not exist locally, so it will use the npm repo as it's doing now. No symlinks needed,yarn workspace
handle this for us out of the boxAddresses:
Screenshots
Documentation