Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore - use pro as submodule #10267

Merged
merged 114 commits into from
Apr 19, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
114 commits
Select commit Hold shift + click to select a range
1a62af6
Setup submodule
adrinr Apr 11, 2023
527242d
Tweak packages to accept the current pro shape
adrinr Apr 11, 2023
5e2a9ed
Change references on jest
adrinr Apr 11, 2023
23d4a42
Remove scripts
adrinr Apr 11, 2023
075a3f6
Bootstrap using submodule
adrinr Apr 11, 2023
3b66d37
Change type references
adrinr Apr 11, 2023
5a256ad
Remove .gitmodules
adrinr Apr 11, 2023
ee5743d
Setup pro
adrinr Apr 11, 2023
f2cb16b
Remove install pro in pipelines
adrinr Apr 11, 2023
a324187
Pull submodules on actions
adrinr Apr 12, 2023
5a621e2
Add token
adrinr Apr 12, 2023
bfb9d16
Remove test pro
adrinr Apr 12, 2023
9c0d61f
Update submodule
adrinr Apr 12, 2023
3942c63
Fix cross references
adrinr Apr 12, 2023
41f308e
Undo yarn.lock changes
adrinr Apr 12, 2023
11e0ad4
Run pro bootstrap if submodule exists
adrinr Apr 12, 2023
2a680b9
Use yarn workspaces with nx
adrinr Apr 3, 2023
684229e
Remove unused yarn.lock
adrinr Apr 3, 2023
7e2f1ce
Update yarn.lock
adrinr Apr 12, 2023
eddb8a2
Remove wrong pro commit
adrinr Apr 12, 2023
a5f53ab
Add missing types
adrinr Apr 12, 2023
85fddeb
Remove bootstrap
adrinr Apr 12, 2023
94d46fd
Remove types
adrinr Apr 12, 2023
e9e382a
Add missing dependency
adrinr Apr 12, 2023
8924c0e
Fix string-templates tests
adrinr Apr 12, 2023
ce94274
Fix backend-core tests
adrinr Apr 12, 2023
75cc6a4
Add yarn link (needed for some test path refs)
adrinr Apr 12, 2023
986e02d
Add runner
adrinr Apr 12, 2023
aff7007
Add packages
adrinr Apr 13, 2023
7567940
Merge branch 'chore/yarn_workspaces' into chore/pro_as_submodule
adrinr Apr 13, 2023
2d77567
Remove "root" from refrenced packages
adrinr Apr 13, 2023
56f8613
Bootstrap submodule
adrinr Apr 13, 2023
267a19a
Update submodule
adrinr Apr 13, 2023
a653e04
Merge branch 'chore/yarn_workspaces' into chore/pro_as_submodule
adrinr Apr 13, 2023
f2ea68d
Update yarn.lock
adrinr Apr 13, 2023
ee81d8f
Update node
adrinr Apr 13, 2023
5af152f
Merge branch 'chore/yarn_workspaces' into chore/pro_as_submodule
adrinr Apr 13, 2023
142e748
Fix jest when no pro access
adrinr Apr 14, 2023
0265961
Pull submodule automatically
adrinr Apr 16, 2023
9cd0798
Undo node version update
adrinr Apr 17, 2023
2769593
Remove not required references
adrinr Apr 17, 2023
236aac7
Update scripts
adrinr Apr 17, 2023
44e0a7a
Update refs
adrinr Apr 17, 2023
a88784c
Add post checkout hook
adrinr Apr 17, 2023
8abaa77
Update
adrinr Apr 17, 2023
d9b67a6
Change hook
adrinr Apr 17, 2023
14e29ed
Fix
adrinr Apr 17, 2023
af036f6
Try config
adrinr Apr 17, 2023
47235ca
Update husky
adrinr Apr 17, 2023
e8c24aa
Attempt
adrinr Apr 17, 2023
ed0841c
Fix hook
adrinr Apr 17, 2023
84793d5
Add submodule check
adrinr Apr 17, 2023
254fe64
Add token
adrinr Apr 17, 2023
7d440c0
Fix action
adrinr Apr 17, 2023
6a64f9f
Fix action
adrinr Apr 17, 2023
c632f5d
Fix
adrinr Apr 17, 2023
35be88c
Fix
adrinr Apr 17, 2023
01dd60e
Attempt 55
adrinr Apr 17, 2023
24986ba
Log
adrinr Apr 17, 2023
acd4472
Attempt
adrinr Apr 17, 2023
7ac3ec5
Try using branch name
adrinr Apr 17, 2023
6b8e2d5
Update var
adrinr Apr 17, 2023
d1ba1bd
Use ref
adrinr Apr 17, 2023
28c9982
Clean actions
adrinr Apr 17, 2023
fc2d982
Attempt 1000
adrinr Apr 17, 2023
1478e25
Fix
adrinr Apr 17, 2023
c1bb93b
Fix
adrinr Apr 17, 2023
8bc0224
Next
adrinr Apr 17, 2023
2d188be
Next
adrinr Apr 17, 2023
0404f20
Attempt 2
adrinr Apr 17, 2023
3760ca8
Git log
adrinr Apr 17, 2023
cdad097
Add git fetch
adrinr Apr 17, 2023
64d02db
More logs
adrinr Apr 17, 2023
1a722c3
..
adrinr Apr 17, 2023
a6c8ba1
Try
adrinr Apr 17, 2023
9bbfec3
Logs
adrinr Apr 17, 2023
fb94a40
Logging log
adrinr Apr 18, 2023
412748b
Fetch history
adrinr Apr 18, 2023
67d0267
Log less
adrinr Apr 18, 2023
9544bc9
Remove origin from branch
adrinr Apr 18, 2023
1f37bf4
Copy
adrinr Apr 18, 2023
33ee5ab
Next attempt
adrinr Apr 18, 2023
eee8851
Attempt with fetch
adrinr Apr 18, 2023
2d483f3
Add origin
adrinr Apr 18, 2023
1e6d5df
Working! Branch pointing to develop
adrinr Apr 18, 2023
605d577
Test if fetch depth 2 works
adrinr Apr 18, 2023
615078b
Use current sha
adrinr Apr 18, 2023
de2375e
Extract
adrinr Apr 18, 2023
eda0f14
Add fetch-depth 0 back
adrinr Apr 18, 2023
327aa09
Use recursive
adrinr Apr 18, 2023
1033142
Try
adrinr Apr 18, 2023
483f003
Fetch all branches
adrinr Apr 18, 2023
d1173d2
Log branches
adrinr Apr 18, 2023
0ca1d84
Next
adrinr Apr 18, 2023
f95a60f
More logs
adrinr Apr 18, 2023
b654e95
Remove logs
adrinr Apr 18, 2023
bb21cf2
Test
adrinr Apr 18, 2023
aa6c8d3
Fetch origin
adrinr Apr 18, 2023
7302237
Fetch depth
adrinr Apr 18, 2023
a192080
Try remote update
adrinr Apr 18, 2023
4d6834f
Back to the working version
adrinr Apr 18, 2023
6163f32
Add more dev info
adrinr Apr 18, 2023
650d288
Merge branch 'develop' into chore/pro_as_submodule
adrinr Apr 18, 2023
da65fdb
Split test-pro from test
adrinr Apr 18, 2023
877b82d
Update pro ref
adrinr Apr 18, 2023
b47bf98
Use nx for build:dev
adrinr Apr 19, 2023
58d0aa8
Link pro only when it exists locally
adrinr Apr 19, 2023
633d04b
Update pro ref
adrinr Apr 19, 2023
cd5083b
Force clean on dep:clean
adrinr Apr 19, 2023
899cd77
Complete `submodules:unload` script
adrinr Apr 19, 2023
8000287
Merge branch 'develop' into chore/pro_as_submodule
adrinr Apr 19, 2023
cb65b81
Update yarn.lock
adrinr Apr 19, 2023
a3294ca
Update pro ref
adrinr Apr 19, 2023
41db6ba
Update pro ref
adrinr Apr 19, 2023
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
75 changes: 50 additions & 25 deletions .github/workflows/budibase_ci.yml
Original file line number Diff line number Diff line change
@@ -1,45 +1,46 @@
name: Budibase CI

on:
# Trigger the workflow on push or pull request,
# but only for the master branch
push:
on:
# Trigger the workflow on push or pull request,
# but only for the master branch
push:
branches:
- master
- develop
pull_request:
- develop
pull_request:
branches:
- master
- develop
workflow_dispatch:
workflow_dispatch:

env:
BRANCH: ${{ github.event.pull_request.head.ref }}
BASE_BRANCH: ${{ github.event.pull_request.base.ref}}
PERSONAL_ACCESS_TOKEN : ${{ secrets.PERSONAL_ACCESS_TOKEN }}
PERSONAL_ACCESS_TOKEN: ${{ secrets.PERSONAL_ACCESS_TOKEN }}

jobs:
lint:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2
- name: Use Node.js 14.x
uses: actions/setup-node@v1
with:
node-version: 14.x
- run: yarn
- run: yarn lint
- uses: actions/checkout@v2
- name: Use Node.js 14.x
uses: actions/setup-node@v1
with:
node-version: 14.x
- run: yarn
- run: yarn lint

build:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2
with:
submodules: true
token: ${{ secrets.PERSONAL_ACCESS_TOKEN }}
- name: Use Node.js 14.x
uses: actions/setup-node@v1
with:
node-version: 14.x
- name: Install Pro
run: yarn install:pro $BRANCH $BASE_BRANCH
- run: yarn
- run: yarn bootstrap
- run: yarn build
Expand All @@ -48,16 +49,17 @@ jobs:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2
with:
submodules: true
token: ${{ secrets.PERSONAL_ACCESS_TOKEN }}
- name: Use Node.js 14.x
uses: actions/setup-node@v1
with:
node-version: 14.x
- name: Install Pro
run: yarn install:pro $BRANCH $BASE_BRANCH
- run: yarn
- run: yarn bootstrap
- run: yarn build
- run: yarn test
- run: yarn test --ignore=@budibase/pro
- uses: codecov/codecov-action@v3
with:
token: ${{ secrets.CODECOV_TOKEN }} # not required for public repos
Expand All @@ -68,26 +70,28 @@ jobs:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2
with:
submodules: true
token: ${{ secrets.PERSONAL_ACCESS_TOKEN }}
- name: Use Node.js 14.x
uses: actions/setup-node@v1
with:
node-version: 14.x
- name: Install Pro
run: yarn install:pro $BRANCH $BASE_BRANCH
- run: yarn
- run: yarn bootstrap
- run: yarn test:pro
- run: yarn test --scope=@budibase/pro

integration-test:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2
with:
submodules: true
token: ${{ secrets.PERSONAL_ACCESS_TOKEN }}
- name: Use Node.js 14.x
uses: actions/setup-node@v1
with:
node-version: 14.x
- name: Install Pro
run: yarn install:pro $BRANCH $BASE_BRANCH
- run: yarn && yarn bootstrap && yarn build
- run: |
cd qa-core
Expand All @@ -96,3 +100,24 @@ jobs:
env:
BB_ADMIN_USER_EMAIL: admin
BB_ADMIN_USER_PASSWORD: admin

check-pro-submodule:
runs-on: ubuntu-latest
steps:
- name: Checkout code
uses: actions/checkout@v2
with:
submodules: true
token: ${{ secrets.PERSONAL_ACCESS_TOKEN }}
fetch-depth: 0
- name: Check submodule
run: |
cd packages/pro
git fetch
if ! git merge-base --is-ancestor $(git log -n 1 --pretty=format:%H) origin/develop; then
echo "Current commit has not been merged to develop"
echo "Refer to the pro repo to merge your changes: https://github.com/Budibase/budibase-pro/blob/develop/docs/getting_started.md"
exit 1
else
echo "All good, the submodule had been merged!"
fi
46 changes: 23 additions & 23 deletions .github/workflows/release-develop.yml
Original file line number Diff line number Diff line change
@@ -1,21 +1,21 @@
name: Budibase Prerelease
concurrency: release-prerelease

on:
push:
on:
push:
branches:
- develop
paths:
- '.aws/**'
- '.github/**'
- 'charts/**'
- 'packages/**'
- 'scripts/**'
- 'package.json'
- 'yarn.lock'
- 'package.json'
- 'yarn.lock'
workflow_dispatch:
- ".aws/**"
- ".github/**"
- "charts/**"
- "packages/**"
- "scripts/**"
- "package.json"
- "yarn.lock"
- "package.json"
- "yarn.lock"
workflow_dispatch:

env:
# Posthog token used by ui at build time
Expand All @@ -24,43 +24,43 @@ env:
INTERCOM_TOKEN: ${{ secrets.INTERCOM_TOKEN }}
PERSONAL_ACCESS_TOKEN: ${{ secrets.PERSONAL_ACCESS_TOKEN }}
FEATURE_PREVIEW_URL: https://budirelease.live

jobs:
release-images:
runs-on: ubuntu-latest
runs-on: ubuntu-latest

steps:
- name: Fail if branch is not develop
if: github.ref != 'refs/heads/develop'
run: |
if: github.ref != 'refs/heads/develop'
run: |
echo "Ref is not develop, you must run this job from develop."
exit 1
- uses: actions/checkout@v2
with:
submodules: true
token: ${{ secrets.PERSONAL_ACCESS_TOKEN }}
- uses: actions/setup-node@v1
with:
node-version: 14.x

- name: Install Pro
run: yarn install:pro develop

- run: yarn
- run: yarn
- run: yarn bootstrap
- run: yarn build
- run: yarn build:sdk
# - run: yarn test
# - run: yarn test

- name: Publish budibase packages to NPM
env:
NPM_TOKEN: ${{ secrets.NPM_TOKEN }}
run: |
run: |
# setup the username and email.
git config --global user.name "Budibase Staging Release Bot"
git config --global user.email "<>"
echo //registry.npmjs.org/:_authToken=${NPM_TOKEN} >> .npmrc
yarn release:develop

- name: Build/release Docker images
run: |
run: |
docker login -u $DOCKER_USER -p $DOCKER_PASSWORD
yarn build:docker:develop
env:
Expand Down
60 changes: 30 additions & 30 deletions .github/workflows/release-master.yml
Original file line number Diff line number Diff line change
Expand Up @@ -2,55 +2,55 @@ name: Budibase Release
concurrency: release

on:
push:
push:
branches:
- master
paths:
- '.aws/**'
- '.github/**'
- 'charts/**'
- 'packages/**'
- 'scripts/**'
- 'package.json'
- 'yarn.lock'
- 'package.json'
- 'yarn.lock'
workflow_dispatch:
inputs:
versioning:
type: choice
description: "Versioning type: patch, minor, major"
default: patch
options:
- patch
- minor
- major
required: true
- ".aws/**"
- ".github/**"
- "charts/**"
- "packages/**"
- "scripts/**"
- "package.json"
- "yarn.lock"
- "package.json"
- "yarn.lock"
workflow_dispatch:
inputs:
versioning:
type: choice
description: "Versioning type: patch, minor, major"
default: patch
options:
- patch
- minor
- major
required: true

env:
# Posthog token used by ui at build time
# Posthog token used by ui at build time
POSTHOG_TOKEN: phc_bIjZL7oh2GEUd2vqvTBH8WvrX0fWTFQMs6H5KQxiUxU
INTERCOM_TOKEN: ${{ secrets.INTERCOM_TOKEN }}
SENTRY_DSN: ${{ secrets.SENTRY_DSN }}
PERSONAL_ACCESS_TOKEN : ${{ secrets.PERSONAL_ACCESS_TOKEN }}
PERSONAL_ACCESS_TOKEN: ${{ secrets.PERSONAL_ACCESS_TOKEN }}

jobs:
release-images:
runs-on: ubuntu-latest
steps:
- name: Fail if branch is not master
if: github.ref != 'refs/heads/master'
run: |
if: github.ref != 'refs/heads/master'
run: |
echo "Ref is not master, you must run this job from master."
exit 1
- uses: actions/checkout@v2
with:
submodules: true
token: ${{ secrets.PERSONAL_ACCESS_TOKEN }}
- uses: actions/setup-node@v1
with:
node-version: 14.x

- name: Install Pro
run: yarn install:pro master

- run: yarn
- run: yarn bootstrap
- run: yarn lint
Expand All @@ -68,12 +68,12 @@ jobs:
echo //registry.npmjs.org/:_authToken=${NPM_TOKEN} >> .npmrc
yarn release

- name: 'Get Previous tag'
- name: "Get Previous tag"
id: previoustag
uses: "WyriHaximus/github-action-get-previous-tag@v1"

- name: Build/release Docker images
run: |
run: |
docker login -u $DOCKER_USER -p $DOCKER_PASSWORD
yarn build
yarn build:docker
Expand Down
3 changes: 3 additions & 0 deletions .gitmodules
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
[submodule "packages/pro"]
path = packages/pro
url = git@github.com:Budibase/budibase-pro.git
4 changes: 4 additions & 0 deletions .husky/post-checkout
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
# .husky/post-checkout
# ...

git config submodule.recurse true
Loading