Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Grid improvements and fixes #10544

Merged
merged 5 commits into from
May 11, 2023
Merged

Grid improvements and fixes #10544

merged 5 commits into from
May 11, 2023

Conversation

aptkingston
Copy link
Member

Description

This PR contains a few improvements and fixes for the grid.

  • New context menu options for copying the row _id or _rev fields (raised internally by @PClmnt)
    image
  • Fix row updates not showing formula column updates [Grid System] - Formula columns do not recalculate when changes are made to cells #10536
  • Fix being able to delete formula cell values
  • Fix not being able to type the year in date cells (raised internally by @melohagan)
  • Add support for opening and closing date cells using keyboard
  • Fix issue where using the delete or backspace keys to clear a date cell would cause a 409 document conflict
  • Disable most context menu options for the new row component
    image

melohagan
melohagan approved these changes May 11, 2023
View reviewed changes
Copy link
Collaborator

@melohagan melohagan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

PClmnt
PClmnt approved these changes May 11, 2023
View reviewed changes
Copy link
Collaborator

@PClmnt PClmnt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aptkingston aptkingston merged commit 7ace8ee into develop May 11, 2023
@aptkingston aptkingston deleted the grid-id branch May 11, 2023 16:23
@github-actions github-actions bot locked and limited conversation to collaborators May 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@melohagan melohagan melohagan approved these changes

@PClmnt PClmnt PClmnt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aptkingston @PClmnt @melohagan