Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hotfix for time-only date picker problems (reverting flatpickr to previous version) #10631

Merged
merged 1 commit into from
May 17, 2023

Conversation

andz-bb
Copy link
Contributor

@andz-bb andz-bb commented May 17, 2023

@aptkingston already fixed this yesterday but only in develop (#10612). This fix is to add the critical part to master for a quick fix to prevent screens affected by the bug from completely breaking. The rest of the cheeks grid time picker changes are in develop and will be included in the next iteration.

Addresses:
#10609

Documentation

  • I have reviewed the budibase documentation to verify if this feature requires any changes. If changes or new docs are required I have written them.

@andz-bb andz-bb requested a review from aptkingston May 17, 2023 15:19
Copy link
Member

@aptkingston aptkingston left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@codecov-commenter
Copy link

Codecov Report

Merging #10631 (beda1ba) into master (ad7b12e) will increase coverage by 0.00%.
The diff coverage is 63.63%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@           Coverage Diff           @@
##           master   #10631   +/-   ##
=======================================
  Coverage   69.76%   69.76%           
=======================================
  Files         536      536           
  Lines       19548    19549    +1     
  Branches     3888     3888           
=======================================
+ Hits        13638    13639    +1     
  Misses       5469     5469           
  Partials      441      441           
Impacted Files Coverage Δ
packages/backend-core/src/context/mainContext.ts 52.59% <0.00%> (ø)
packages/backend-core/src/environment.ts 82.08% <50.00%> (ø)
...ackages/server/src/api/controllers/row/internal.ts 81.42% <100.00%> (ø)
packages/server/src/automations/utils.ts 68.61% <100.00%> (+0.23%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@andz-bb andz-bb merged commit 0e7ee50 into master May 17, 2023
@github-actions github-actions bot locked and limited conversation to collaborators May 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants