don't check for hydrationComplete

[mslourens]

Description

I removed the check for hydrationComplete since that boolean was set to true the first time the screen was rendered. When clicking the layouts tab and back to the screens tab, the state was not updated by the url and didn't change anymore. After removing the hydrationComplete boolean, the state was updated correctly.

Fixes #4075

Screenshots

[codecov-commenter]

Codecov Report

Merging #4076 (f3bdedd) into develop (4f9ac15) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff            @@
##           develop    #4076   +/-   ##
========================================
  Coverage    68.91%   68.92%           
========================================
  Files          139      139           
  Lines         4633     4634    +1     
  Branches       685      685           
========================================
+ Hits          3193     3194    +1     
  Misses        1018     1018           
  Partials       422      422           

Impacted Files	Coverage Δ
packages/server/src/middleware/currentapp.js	70.37% <100.00%> (+0.55%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 81218cb...f3bdedd. Read the comment docs.

[shogunpurple]

LGTM!

[aptkingston]

Hey @mslourens! Sorry it took me so long to get round to looking at this.

While you're right that this does solve the problem, the hydrationComplete check in that layout is actually very important as it prevents endless cycles of update state > update url > update state > update url > ....

I've pushed up a PR here with a safer way to fix this: #4681

It's a bit confusing because we have logic in quite a few different places to update state, but the logic that needed updated in this case was the index.svelte file for this route. This file contains a selectValidAsset function which normally selects an asset of a certain type whenever landing on a URL like .../screen or .../layout (without any ID's after it).

The logic in that function is good, but it doesn't account for when no assets of a certain type exist. In this case, that's highlighted by a new app. If we don't have any screens, then we never updated state, and the builder (and preview) always think that a layout is still selected. That's why the preview app and the builder didn't properly update, as described in your issue.

Hopefully that makes some sense! It took me a while to get to the bottom of this - it's a complicated issue.

[mslourens]

Hey Andrew, thanks for the explanation, the issue is indeed much more complicated than just removing the check, I didn't realise it. This just shows how complicated the builder is and that I should dig deeper with issues like these... I'll close this PR.