Fix asset type selection #4681
Merged
Fix asset type selection #4681
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… preview is always remounted properly
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a quick fix for #4075. The real issue was that whenever no assets of a certain type exist (for example when you have no screens in a fresh app), and you click on layouts and then back to screens, state was not update as a valid screen could not be found. This mean that the client preview never changed. The logic that normally updates state is inside
packages/builder/src/pages/builder/app/[application]/design/[assetType]/index.svelte.The issue was compounded with the fact that client app previews inside the builder did not always remount properly, if you toggled between a layout and a screen that shared the same layout ID. This PR fixes this by adding the current builder preview asset type to the keying of the rendering of the layout. This is fine for production apps too as this string will always just evaluate to
null.