-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
increase burst limit, remove log mounts #4481
Conversation
…fying join type as string is old which doesn't work in latest versions of knex.
Fix for joins in SQL tables
Fix for query preview validation
Remount button action components fully
Codecov Report
@@ Coverage Diff @@
## master #4481 +/- ##
=======================================
Coverage 67.92% 67.92%
=======================================
Files 144 144
Lines 4923 4923
Branches 761 761
=======================================
Hits 3344 3344
Misses 1105 1105
Partials 474 474
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Just some feed back since I was playing with it this AM,
|
e6f8f81
to
387e503
Compare
CLA Assistant Lite bot: I have read the CLA Document and I hereby sign the CLA 4 out of 5 committers have signed the CLA. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is awesome work @shogunpurple 🥳 love it.
proxy_pass http://app-service.budibase.svc.cluster.local:4002; | ||
{{#if watchtower}} | ||
location = /v1/update { | ||
proxy_pass http://watchtower-service:8080; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should use the watchtower variable name here - http://$watchtower:8080;
Description
A few fixes for running BB in docker self hosted setups:
logs
Screenshots
If a UI facing feature, some screenshots of the new functionality.