-
Notifications
You must be signed in to change notification settings - Fork 1.1k
feat: add accessibility and focusOnChange settings to carousel #4156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add accessibility and focusOnChange settings to carousel #4156
Conversation
|
|
| Command | Status | Duration | Result |
|---|---|---|---|
nx test @snippet/angular-17-ssr |
❌ Failed | 5m 21s | View ↗ |
nx test @snippet/vue |
❌ Failed | 2m 49s | View ↗ |
nx test @snippet/svelte |
❌ Failed | 2m 56s | View ↗ |
nx test @snippet/angular-17 |
❌ Failed | 4m 41s | View ↗ |
nx test @snippet/react |
❌ Failed | 1m 53s | View ↗ |
nx test @e2e/qwik-city |
✅ Succeeded | 10m 44s | View ↗ |
nx test @e2e/angular-17 |
✅ Succeeded | 8m 38s | View ↗ |
nx test @e2e/react-sdk-next-14-app |
✅ Succeeded | 7m 46s | View ↗ |
Additional runs (37) |
✅ Succeeded | ... | View ↗ |
☁️ Nx Cloud last updated this comment at 2025-09-30 16:03:06 UTC
Signed-off-by: Sanyam Kamat <1625114+sanyamkamat@users.noreply.github.com>
Signed-off-by: Sanyam Kamat <1625114+sanyamkamat@users.noreply.github.com>
Signed-off-by: Sanyam Kamat <1625114+sanyamkamat@users.noreply.github.com>
Signed-off-by: Sanyam Kamat <1625114+sanyamkamat@users.noreply.github.com>
53dc489 to
06a3a4e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bug: Type Dependencies Misplaced in Production
The package-lock.json incorrectly lists @types/react-slick and its transitive type dependencies (@types/react, @types/prop-types, @types/scheduler) as production dependencies, though type definitions belong in devDependencies. This creates an inconsistency with package.json for @types/react-slick, potentially increasing package size and causing installation issues. Separately, the root package-lock.json version (2.1.0) doesn't match the packages[""] entry (2.0.3).
packages/widgets/package-lock.json#L8-L14
builder/packages/widgets/package-lock.json
Lines 8 to 14 in 692c7a5
| "name": "@builder.io/widgets", | |
| "version": "2.0.3", | |
| "license": "MIT", | |
| "dependencies": { | |
| "@emotion/core": ">=10", | |
| "@emotion/styled": ">=10", | |
| "@types/react-slick": "^0.23.13", |
packages/widgets/package-lock.json#L5725-L5732
builder/packages/widgets/package-lock.json
Lines 5725 to 5732 in 692c7a5
| "resolved": "https://registry.npmjs.org/@types/prop-types/-/prop-types-15.7.13.tgz", | |
| "integrity": "sha512-hCZTSvwbzWGvhqxp/RqVqwU999pBf2vp7hzIjiYOsl8wqOmUxkQ6ddw1cV3l8811+kdUFus/q4d1Y3E3SyEifA==", | |
| "license": "MIT" | |
| }, | |
| "node_modules/@types/react": { | |
| "version": "16.14.62", | |
| "resolved": "https://registry.npmjs.org/@types/react/-/react-16.14.62.tgz", | |
| "integrity": "sha512-BWf7hqninZav6nerxXj+NeZT/mTpDeG6Lk2zREHAy63CrnXoOGPGtNqTFYFN/sqpSaREDP5otVV88axIXmKfGA==", |
packages/widgets/package-lock.json#L5782-L5784
builder/packages/widgets/package-lock.json
Lines 5782 to 5784 in 692c7a5
| "resolved": "https://registry.npmjs.org/@types/scheduler/-/scheduler-0.16.8.tgz", | |
| "integrity": "sha512-WZLiwShhwLRmeV6zH+GkbOFT6Z6VklCItrDioxUnv+u4Ll+8vKeFySoFyK/0ctcRpOmwAicELfmys1sDc/Rw+A==", | |
| "license": "MIT" |
Description
Adding these settings to help make the carousel component compliant with a11y requirements. Settings default to off so that existing workflows are not disrupted.
JIRA ticket
https://builder-io.atlassian.net/browse/ENG-10325
Note
Adds accessibility and focusOnSelect options to the Carousel and upgrades react-slick, with a minor version bump and related dependency updates.
accessibilityandfocusOnSelectinputs inCarousel.config.ts(advanced, defaultfalse).accessibilityandfocusOnSelectprops toreact-slickinCarousel.tsx.react-slickto^0.31.0and@types/react-slickto^0.23.13.enquire.js.2.1.0and addrelease:minorscript.Written by Cursor Bugbot for commit 692c7a5. This will update automatically on new commits. Configure here.