Skip to content

Conversation

@murrayadam
Copy link
Contributor

@murrayadam murrayadam commented Sep 29, 2025

Description

Adding these settings to help make the carousel component compliant with a11y requirements. Settings default to off so that existing workflows are not disrupted.

JIRA ticket
https://builder-io.atlassian.net/browse/ENG-10325


Note

Adds accessibility and focusOnSelect options to the Carousel and upgrades react-slick, with a minor version bump and related dependency updates.

  • Widgets/Carousel:
    • Add accessibility and focusOnSelect inputs in Carousel.config.ts (advanced, default false).
    • Pass accessibility and focusOnSelect props to react-slick in Carousel.tsx.
  • Dependencies:
    • Upgrade react-slick to ^0.31.0 and @types/react-slick to ^0.23.13.
    • Lockfile reflects updated peer ranges and removal of transitive enquire.js.
  • Release & Scripts:
    • Bump package version to 2.1.0 and add release:minor script.

Written by Cursor Bugbot for commit 692c7a5. This will update automatically on new commits. Configure here.

@changeset-bot
Copy link

changeset-bot bot commented Sep 29, 2025

⚠️ No Changeset found

Latest commit: 692c7a5

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@nx-cloud
Copy link

nx-cloud bot commented Sep 29, 2025

🤖 Nx Cloud AI Fix Eligible

An automatically generated fix could have helped fix failing tasks for this run, but Self-healing CI is disabled for this workspace. Visit workspace settings to enable it and get automatic fixes in future runs.

To disable these notifications, a workspace admin can disable them in workspace settings.


View your CI Pipeline Execution ↗ for commit 692c7a5

Command Status Duration Result
nx test @snippet/angular-17-ssr ❌ Failed 5m 21s View ↗
nx test @snippet/vue ❌ Failed 2m 49s View ↗
nx test @snippet/svelte ❌ Failed 2m 56s View ↗
nx test @snippet/angular-17 ❌ Failed 4m 41s View ↗
nx test @snippet/react ❌ Failed 1m 53s View ↗
nx test @e2e/qwik-city ✅ Succeeded 10m 44s View ↗
nx test @e2e/angular-17 ✅ Succeeded 8m 38s View ↗
nx test @e2e/react-sdk-next-14-app ✅ Succeeded 7m 46s View ↗
Additional runs (37) ✅ Succeeded ... View ↗

☁️ Nx Cloud last updated this comment at 2025-09-30 16:03:06 UTC

murrayadam and others added 4 commits September 30, 2025 20:47
Signed-off-by: Sanyam Kamat <1625114+sanyamkamat@users.noreply.github.com>
Signed-off-by: Sanyam Kamat <1625114+sanyamkamat@users.noreply.github.com>
Signed-off-by: Sanyam Kamat <1625114+sanyamkamat@users.noreply.github.com>
Signed-off-by: Sanyam Kamat <1625114+sanyamkamat@users.noreply.github.com>
@sanyamkamat sanyamkamat force-pushed the update-carousel-settings-20250929 branch from 53dc489 to 06a3a4e Compare September 30, 2025 15:19
cursor[bot]

This comment was marked as outdated.

@sanyamkamat sanyamkamat enabled auto-merge (squash) September 30, 2025 15:39
Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Type Dependencies Misplaced in Production

The package-lock.json incorrectly lists @types/react-slick and its transitive type dependencies (@types/react, @types/prop-types, @types/scheduler) as production dependencies, though type definitions belong in devDependencies. This creates an inconsistency with package.json for @types/react-slick, potentially increasing package size and causing installation issues. Separately, the root package-lock.json version (2.1.0) doesn't match the packages[""] entry (2.0.3).

packages/widgets/package-lock.json#L8-L14

"name": "@builder.io/widgets",
"version": "2.0.3",
"license": "MIT",
"dependencies": {
"@emotion/core": ">=10",
"@emotion/styled": ">=10",
"@types/react-slick": "^0.23.13",

packages/widgets/package-lock.json#L5725-L5732

"resolved": "https://registry.npmjs.org/@types/prop-types/-/prop-types-15.7.13.tgz",
"integrity": "sha512-hCZTSvwbzWGvhqxp/RqVqwU999pBf2vp7hzIjiYOsl8wqOmUxkQ6ddw1cV3l8811+kdUFus/q4d1Y3E3SyEifA==",
"license": "MIT"
},
"node_modules/@types/react": {
"version": "16.14.62",
"resolved": "https://registry.npmjs.org/@types/react/-/react-16.14.62.tgz",
"integrity": "sha512-BWf7hqninZav6nerxXj+NeZT/mTpDeG6Lk2zREHAy63CrnXoOGPGtNqTFYFN/sqpSaREDP5otVV88axIXmKfGA==",

packages/widgets/package-lock.json#L5782-L5784

"resolved": "https://registry.npmjs.org/@types/scheduler/-/scheduler-0.16.8.tgz",
"integrity": "sha512-WZLiwShhwLRmeV6zH+GkbOFT6Z6VklCItrDioxUnv+u4Ll+8vKeFySoFyK/0ctcRpOmwAicELfmys1sDc/Rw+A==",
"license": "MIT"

Fix in Cursor Fix in Web


@sanyamkamat sanyamkamat merged commit 220b988 into BuilderIO:main Sep 30, 2025
43 of 48 checks passed
midhunadarvin added a commit that referenced this pull request Oct 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants