-
Notifications
You must be signed in to change notification settings - Fork 1.1k
[DO NOT MERGE] Testing #4160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DO NOT MERGE] Testing #4160
Conversation
|
| "react": "^0.14.0 || ^15.0.1 || ^16.0.0 || ^17.0.0 || ^18.0.0 || ^19.0.0", | ||
| "react-dom": "^0.14.0 || ^15.0.1 || ^16.0.0 || ^17.0.0 || ^18.0.0 || ^19.0.0" | ||
| "react": "^0.14.0 || ^15.0.1 || ^16.0.0 || ^17.0.0", | ||
| "react-dom": "^0.14.0 || ^15.0.1 || ^16.0.0 || ^17.0.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bug: React-Slick Version Conflict
Downgrading react-slick to ^0.28.1 introduces a peer dependency conflict. This react-slick version supports React only up to v17, but the package's peerDependencies still declare compatibility with React 18 and 19. This mismatch can cause warnings or runtime issues for users on those React versions.
Additional Locations (1)
|
| Command | Status | Duration | Result |
|---|---|---|---|
nx test @snippet/angular-17-ssr |
❌ Failed | 6m 3s | View ↗ |
nx test @snippet/angular-17 |
❌ Failed | 4m 55s | View ↗ |
nx test @snippet/react |
❌ Failed | 3m 18s | View ↗ |
nx test @snippet/vue |
❌ Failed | 2m 50s | View ↗ |
nx test @snippet/svelte |
❌ Failed | 2m 40s | View ↗ |
nx test @e2e/qwik-city |
✅ Succeeded | 10m 32s | View ↗ |
nx test @e2e/nextjs-sdk-next-app |
✅ Succeeded | 8m 15s | View ↗ |
nx test @e2e/nuxt |
✅ Succeeded | 9m 8s | View ↗ |
Additional runs (37) |
✅ Succeeded | ... | View ↗ |
☁️ Nx Cloud last updated this comment at 2025-10-01 09:37:30 UTC
|
| Command | Status | Duration | Result |
|---|---|---|---|
nx test @snippet/angular-17-ssr |
❌ Failed | 6m 3s | View ↗ |
nx test @snippet/angular-17 |
❌ Failed | 4m 55s | View ↗ |
nx test @snippet/react |
❌ Failed | 3m 18s | View ↗ |
nx test @snippet/vue |
❌ Failed | 2m 50s | View ↗ |
nx test @snippet/svelte |
❌ Failed | 2m 40s | View ↗ |
nx test @e2e/react-sdk-next-pages |
✅ Succeeded | 6m 54s | View ↗ |
nx test @e2e/react-sdk-next-14-app |
✅ Succeeded | 6m 46s | View ↗ |
nx test @e2e/gen1-next15-app |
✅ Succeeded | 6m 49s | View ↗ |
Additional runs (30) |
✅ Succeeded | ... | View ↗ |
☁️ Nx Cloud last updated this comment at 2025-10-01 09:27:57 UTC
…l (#4156)"
This reverts commit 220b988.
Description
Add a short description of what changes you made, why you made them, and any other context that you think might be helpful for someone to better understand what is contained in this pull request. This sort of information is useful for people reviewing the code, as well as anyone from the future trying to understand why changes were made or why a bug started happening.
Screenshot
If relevant, add a screenshot or two of the changes you made.
Note
Downgrades react-slick and removes Carousel accessibility/focus options, updating package versions and lockfile accordingly.
packages/widgets):2.0.3.react-slickto^0.28.1and@types/react-slickto^0.23.4; lockfile updated (addsenquire.js, narrows peer ranges).accessibilityandfocusOnSelectinputs fromCarousel.config.ts.Carousel.tsxand stop passing them toSlider.Written by Cursor Bugbot for commit 7d0dff6. This will update automatically on new commits. Configure here.