Skip to content

[DO NOT MERGE] Testing #4160

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
midhunadarvin wants to merge 1 commit into from
Closed

[DO NOT MERGE] Testing #4160

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 19 additions & 8 deletions packages/widgets/package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

23 changes: 11 additions & 12 deletions packages/widgets/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@builder.io/widgets",
"version": "2.1.0",
"version": "2.0.3",
"description": "",
"keywords": [],
"main": "dist/builder-widgets.cjs.js",
Expand Down Expand Up @@ -35,7 +35,6 @@
"commit": "git-cz",
"release": "npm run build && ALLOW_PUBLISH=true npm publish",
"release:major": "npm run build && npm version major && ALLOW_PUBLISH=true npm publish",
"release:minor": "npm run build && npm version minor && ALLOW_PUBLISH=true npm publish",
"release:patch": "npm run build && npm version patch --no-git-tag-version && ALLOW_PUBLISH=true npm publish",
"release:nightly": "npm run build && npm version prerelease --no-git-tag-version && ALLOW_PUBLISH=true npm publish --tag nightly",
"release:dev": "npm run build && npm version prerelease --no-git-tag-version && ALLOW_PUBLISH=true npm publish --tag dev",
Expand Down Expand Up @@ -94,23 +93,21 @@
"@types/react": "^16.4.1",
"@types/react-dom": "^16.0.7",
"@types/react-loadable": "^5.5.1",
"@types/react-slick": "^0.23.13",
"@types/react-slick": "^0.23.4",
"colors": "^1.1.2",
"commitizen": "^4.3.1",
"concurrently": "^5.3.0",
"coveralls": "^3.0.0",
"cross-env": "^5.0.1",
"cz-conventional-changelog": "^2.0.0",
"concurrently": "^5.3.0",
"rollup-plugin-serve": "^1.0.1",
"husky": "^0.14.0",
"jest": "^29.0.0",
"lint-staged": "^15.3.0",
"lodash.camelcase": "^4.3.0",
"next": "^12.1.0",
"npm-install-peers": "^1.2.1",
"prettier": "^1.4.4",
"prompt": "^1.0.0",
"react": "^17.0.2",
"react-dom": "^17.0.2",
"replace-in-file": "^3.0.0-beta.2",
"rimraf": "^2.6.1",
"rollup": "^2.33.3",
Expand All @@ -120,7 +117,6 @@
"rollup-plugin-node-resolve": "^5.2.0",
"rollup-plugin-re": "^1.0.7",
"rollup-plugin-replace": "^2.0.0",
"rollup-plugin-serve": "^1.0.1",
"rollup-plugin-sourcemaps": "^0.6.3",
"rollup-plugin-typescript2": "^0.31.2",
"semantic-release": "^19.0.3",
Expand All @@ -131,15 +127,18 @@
"tslint-config-standard": "^7.0.0",
"typedoc": "^0.26.10",
"typescript": "^5.4.5",
"validate-commit-msg": "^2.12.2"
"validate-commit-msg": "^2.12.2",
"next": "^12.1.0",
"react": "^17.0.2",
"react-dom": "^17.0.2"
},
"peerDependencies": {
"@builder.io/react": ">=5.0.11",
"next": ">=12.1.0",
"preact": "^8.4.2",
"preact-compat": "^3.18.4",
"preact-context": "^1.1.3",
"prop-types": "^15.7.2",
"next": ">=12.1.0",
"@builder.io/react": ">=5.0.11",
"react": ">=16.0.0-0 || ^19.0.0-rc",
"react-dom": ">=16.0.0-0 || ^19.0.0-rc"
},
Expand All @@ -166,7 +165,7 @@
"lodash-es": "^4.17.10",
"react-loadable": "^5.5.0",
"react-masonry-component": "^6.2.1",
"react-slick": "^0.31.0",
"react-slick": "^0.28.1",
"tslib": "^1.10.0"
},
"gitHead": "4d96fbc32864698afbb355ab991c6d90be991951"
Expand Down
14 changes: 0 additions & 14 deletions packages/widgets/src/components/Carousel.config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -200,19 +200,5 @@ export const carouselConfig: any = {
},
],
},
{
name: 'accessibility',
helperText: 'Enable accessibility features for screen readers and keyboard navigation',
type: 'boolean',
defaultValue: false,
advanced: true,
},
{
name: 'focusOnSelect',
helperText: 'Focus on slide after slide change for better accessibility',
type: 'boolean',
defaultValue: false,
advanced: true,
},
],
};
4 changes: 0 additions & 4 deletions packages/widgets/src/components/Carousel.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,8 +25,6 @@ interface CarouselProps {
useChildrenForSlides?: boolean;
slickProps?: Settings;
responsive?: ResponsiveObject[];
accessibility?: boolean;
focusOnSelect?: boolean;
}

// TODO: change to slick grid
Expand Down Expand Up @@ -102,8 +100,6 @@ export class CarouselComponent extends React.Component<CarouselProps> {
this.props.autoplaySpeed ? this.props.autoplaySpeed * 1000 : undefined
}
dots={!this.props.hideDots}
accessibility={this.props.accessibility}
focusOnSelect={this.props.focusOnSelect}
// TODO: on change emit event on element?
// renderBottomCenterControls={this.props.hideDots ? () => null : undefined}

Expand Down
Loading