rollup extant PRs + BufReadExt uses '&mut self' + serde feature restructuring #114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now that bstr has an 'alloc' feature, we need to rethink how we setup the serde feature flags. Previously, all we had was 'std' and 'no std'. But now we have 'std', 'alloc only' and 'core only'. In particular, 'no std' is split into 'alloc only' and 'core only', since neither one bring in std. To reflect this trichotomy, we rename 'serde1' to 'serde1-std', and split 'serde1-nostd' into 'serde1-alloc' and 'serde1-core'. Closes #111
This matches what std::str::Utf8Error has, and it seems like a common sense impl. We do not add a 'Copy' impl however, since that seems like a backcompat hazard. Although, it does seem unlikely that this error type will ever *not* be 'Copy', it's not clear to me that 'Copy' makes semantic sense for this type. Closes #113
Previously we were accessing BString's inner field. This commit changes it so that everyone is forced to go through a method. Honestly, it's kind of a questionable change, but I think I stylistically prefer this.
The only reason these didn't exist is probably because I built bstr before (or too close to) when TryFrom was stabilized. But TryFrom has been available for quite some time, so it's good sense to add these impls now. Closes #112
Previously, they consumed 'self', but there is no particular reason why they need to do that. Instead, we can borrow self mutably. The two methods that return iterators do continue to consume 'self' though, which matches the style used by 'std' for 'BufRead'.
This adds a convenience constructor for building a BStr slice directly from anything that impls AsRef<[u8]>. This is analogous to, e.g., Path::new from std. While this constructor is redundant, it is often convenient because of its concreteness. Alternatives rely on generics via trait impls, which don't always work seamlessly. Closes #110
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref #40