raftstore: fix failing to restart after tikv OOM crash #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* use flushed last applied index in gc Signed-off-by: qi.xu <tonxuqi@outlook.com>
Add a new config: server.max_snapshot_file_raw_size (size before compression) to limit the write amplification in big region scenario. For scenarios when older version TiKv co-exists (like rolling upgrade), it will rely on feature gate and still use single snapshot file for backward compatibility. Signed-off-by: tonyxuqqi <tonyxuqi@outlook.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: qi.xu tonxuqi@outlook.com
What problem does this PR solve?
Problem Summary:
TiKV may fail to restart after crash because GC may delete data that has not been synced to disk when disable_kv_wal is true.
What is changed and how it works?
Proposal:
What's Changed:
When GC, try to read the truncated index from SST directly to figure out the last index.
Related changes