This repository has been archived by the owner on Apr 2, 2024. It is now read-only.
refactor(BUX-426): remove unused BroadcastClientApis & appropriate With function
#516
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Welcome to our open-source project @chris-4chain! π |
Codecov ReportAll modified and coverable lines are covered by tests β
Additional details and impacted files@@ Coverage Diff @@
## master #516 +/- ##
==========================================
+ Coverage 53.10% 53.12% +0.01%
==========================================
Files 107 107
Lines 11140 11127 -13
==========================================
- Hits 5916 5911 -5
+ Misses 4777 4769 -8
Partials 447 447
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report in Codecov by Sentry.
|
7 tasks
wregulski
approved these changes
Dec 27, 2023
Nazarii-4chain
approved these changes
Dec 27, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
During tests I found out that the
BroadcastClientApisvariable insidechainstateconfig is unused and can be removed along with theWithBroadcastClientAPIsfunction. So I did it. Without removed code, the aplication still compiles, tests pass and it works with bux-server.If the existence of this config variable has some future/planned usage - just cancel this PR.