Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(BUX-426): remove unnecessary WithBroadcastClientAPIs #385

Merged
merged 1 commit into from
Dec 27, 2023

Conversation

chris-4chain
Copy link
Contributor

@chris-4chain chris-4chain commented Dec 27, 2023

Pull Request Checklist

  • πŸ“– I created my PR using provided : CODE_STANDARDS
  • πŸ“– I have read the short Code of Conduct: CODE_OF_CONDUCT
  • 🏠 I tested my changes locally.
  • βœ… I have provided tests for my changes.
  • πŸ“ I have used conventional commits.
  • πŸ“— I have updated any related documentation.
  • πŸ’Ύ PR was issued based on the Github or Jira issue.

According to BuxOrg/bux#516 I removed the WithBroadcastClientAPIs function which set unused chainstate config variable.

Copy link
Contributor

mergify bot commented Dec 27, 2023

Welcome to our open-source project @chris-4chain! πŸ’˜

Copy link

codecov bot commented Dec 27, 2023

Codecov Report

All modified and coverable lines are covered by tests βœ…

Comparison is base (621098e) 39.06% compared to head (ff03233) 39.02%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #385      +/-   ##
==========================================
- Coverage   39.06%   39.02%   -0.04%     
==========================================
  Files          44       44              
  Lines        1577     1576       -1     
==========================================
- Hits          616      615       -1     
  Misses        928      928              
  Partials       33       33              
Flag Coverage Ξ”
unittests 39.02% <ΓΈ> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Ξ”
config/services.go 44.40% <ΓΈ> (-0.19%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Ξ” = absolute <relative> (impact), ΓΈ = not affected, ? = missing data
Powered by Codecov. Last update 621098e...ff03233. Read the comment docs.

@mergify mergify bot merged commit aa41772 into master Dec 27, 2023
11 checks passed
@mergify mergify bot deleted the refactor-426-remove-unused-WithBroadcastClientAPIs branch December 27, 2023 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants