Develop #438
Closed
Develop #438
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* first baby steps to refactor api into smaller pieces.
* capsule some of the request calls * final touches * make mypy happy * add missing file * implement the new paginator design * adjust tests to the new design * trunk catches * remove wrong file * small improvements * make mypy happy * adjust expected result for doctest * further smaller fixes * fix vocab test * automate cancelling outdated workflow runs * fix doctest * fix test expectations * remove tests that don't really make sense. I don't think we should process user supplied URLs too much. * fix trunk check * make API and data schema smarter. Delay init of DBschema to raise API connection error at right place. * full circle and we still don't have the correct search results * reenable tests * stupid mistakes * remove unmerged paths * add missing page increase * add good changes * less error prone * raw is better for debugging * fix import error * remove obsolete test
|
Merging to
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes
Known Issues
Notes
Checklist
CONTRIBUTORS.md) in the pull request source branch.